Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <9324ef33-eedd-b965-37e8-b82e06778aab@0882a8b5-c6c3-11e9-b005-00805fc181fe>
In-Reply-To: <9324ef33-eedd-b965-37e8-b82e06778aab@0882a8b5-c6c3-11e9-b005-00805fc181fe>
From:   Ju Hyung Park <qkrwngud825@gmail.com>
Date:   Thu, 16 Jul 2020 02:37:22 +0900
Message-ID: <CAD14+f0CVzRCJUJBBM=+jQ=UtOhxVJu9naQ9SpgqMqbbaeamiQ@mail.gmail.com>
Subject: Re: [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs
To:     Simon Arlott <simon@octiron.net>, linux-ide@vger.kernel.org
Cc:     Jens Axboe <axboe@kernel.dk>,
        open list <linux-kernel@vger.kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Tejun Heo <tj@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Simon,

On Wed, Jul 15, 2020 at 8:13 PM Simon Arlott <simon@octiron.net> wrote:
> the original justification for
> enabling appears to be based on marketing material with no explanation
> of what has been changed to make the 860 work properly when the earlier
> 840 and 850 both have the same issue.

Yes, this was why I sent out the patch.

With that said though, I've tested 860 EVO at that time(on i5-6200U,
so it's an Intel SATA controller) for a few weeks both with
asynchronous trim via f2fs and manual synchronous trim via fstrim.
(Since I was also using TLP, the SATA controller and the SSD was
constantly switching between LPM mode and non-LPM.)
My unit did not have any problem whereas both my previous 850 PRO and
850 EVO suffered from issues.

My 860 EVO was just fine with no problem for about 1.5 year until
later I switched to NVMe.

Given how late the bug reports were made after my patch went into
mainline, I wonder if this is firmware-specific.

Thanks.

>
> Signed-off-by: Simon Arlott <simon@octiron.net>
> Cc: Park Ju Hyung <qkrwngud825@gmail.com>
> Cc: stable@vger.kernel.org
> Fixes: ca6bfcb2f6d9 ("libata: Enable queued TRIM for Samsung SSD 860")
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b1cd4d97bc2a..02e861aac5ec 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3951,6 +3951,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>                                                 ATA_HORKAGE_ZERO_AFTER_TRIM, },
>         { "Samsung SSD 850*",           NULL,   ATA_HORKAGE_NO_NCQ_TRIM |
>                                                 ATA_HORKAGE_ZERO_AFTER_TRIM, },
> +       { "Samsung SSD 860*",           NULL,   ATA_HORKAGE_NO_NCQ_TRIM |
> +                                               ATA_HORKAGE_ZERO_AFTER_TRIM, },
>         { "FCCT*M500*",                 NULL,   ATA_HORKAGE_NO_NCQ_TRIM |
>                                                 ATA_HORKAGE_ZERO_AFTER_TRIM, },
>
> --
> 2.17.1
>
> --
> Simon Arlott