Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp641102ybh; Wed, 15 Jul 2020 11:13:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrGoYyVXOsiTL2PRMGRuQvKP0kkodqiS8VN4EsQO0ul0bq4NDQTqV9Esq3zITlZ8lbaZbx X-Received: by 2002:a17:906:3784:: with SMTP id n4mr190161ejc.277.1594836822885; Wed, 15 Jul 2020 11:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594836822; cv=none; d=google.com; s=arc-20160816; b=wNQp74OzwaqxUoqcjzE4pYk7aQBzN+fKJjX4u08RFZxVEZzqzoNWylzS51ilMo4UPn NNeithcdmJMSvQYMcwu68rWFthnOrM5L6yWHaGpl/9FTLZViPTmkJy6OEY1t6KtY7Dpc IdSefyC8+nfY0cn/8/vm+EJo5elyHe4wO2FDYvI+Y7PMa6DmKkvA/aX97QgCvu8fKRKC 7FB4BSrclAlqJ4E1339C/dAa9Gf2Mx/9HPeEX3S2SArYJpw7c33aUcJ1DQWmS72ZRzNt Zo6tNFSEyevpT1xA2uyL60wBZhW2k2iI5qWaDZGr0h5IDnAfD2NLjKcVb22zVSH3boDz +j6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1O8gCAk3sHB73r10lZy+GXtbnZOViYIuP0JmkWQ7mtE=; b=Xp6Vo8Hsy0wU2Bifu4QEg9NsUUp+zd4CZmmXm17+67X1yUPqXVLgm6fOXykxww4duV UpCcVjUYE6UkIvmzljviy7pc3YqZlf/dVSn9a1UULU5Bw7RD8nGiJqkb5r8WKQKFgzA2 +RTX10JZf7t+ZmXWRk1+qCYZ31dtflB8fQb4x3y79Y0j4HUqkSW/IiyqbsViqDirsGei txdY1I7wx2llevwINLQ7O8Tyrn3e6oROsdVIPTACxgosZvPe+Qd22ZT3CAHljyEDwSGr PzNOm4VKv/QWcKsW22ylyP0JohG1a11GLb1LOpsKwncl3k+OABMCoIBRgpMpykxa7dUM nK9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="r/IRrR4o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr6si1597069ejb.259.2020.07.15.11.13.18; Wed, 15 Jul 2020 11:13:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="r/IRrR4o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbgGOSM5 (ORCPT + 99 others); Wed, 15 Jul 2020 14:12:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgGOSM4 (ORCPT ); Wed, 15 Jul 2020 14:12:56 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA455C061755; Wed, 15 Jul 2020 11:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1O8gCAk3sHB73r10lZy+GXtbnZOViYIuP0JmkWQ7mtE=; b=r/IRrR4oQJgu4nromds02egPfH kIwrolcHx1rZENxCxqUKYknwwzcYtFosrLaYq7s3GFhwsa11B6zgsAW8mq+XRQpRuTUN0scK02YOy 2SrtYGKWiblsBHH/T6PVMPO4HFs5z959fxTxlihRFxeVpP4bxGk85HZBU/l2OybIh6Sgfu9HZ/cWB oVxu3ipb5/EG7EAAwyYQ+UHoLv9wl1TKeOthEXYUXOM+4cIWOf36ToZN3z2kS1+fVpEd9m54ToTMb hGkEvOKx+8kD9+GPSAYqxQojdmFWSkjHjOJHH5f5k9B/vb+ik7vgQ/hOVjoO/ZepN0DV8QSxaVG/h kbD1rauA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvltc-0004kS-Hp; Wed, 15 Jul 2020 18:12:44 +0000 Date: Wed, 15 Jul 2020 19:12:44 +0100 From: Christoph Hellwig To: Simon Arlott Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Linux Kernel Mailing List , Jonathan Corbet , linux-doc@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Bart Van Assche , Christoph Hellwig , Damien Le Moal , Pavel Machek , Henrique de Moraes Holschuh Subject: Re: [PATCH 2/2] x86/reboot/quirks: Add ASRock Z170 Extreme4 Message-ID: <20200715181244.GB17753@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 09:58:05PM +0100, Simon Arlott wrote: > If a PCI mode reboot is performed on the ASRock Z170 Extreme4, a power > cycle will occur. Automatically set the reboot quirk for this to prepare > for the power off (i.e. stop all disks). > > This will only take effect if PCI mode is manually used. It'll be too late > in the reboot process to prepare for power off if the other reboot methods > fail. > > It is necessary to re-order the processing of DMI checks because this quirk > must apply even if a reboot= command line parameter is used as that's the > only way to specify a PCI mode reboot. > > Signed-off-by: Simon Arlott Looks good, Reviewed-by: Christoph Hellwig