Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp641859ybh; Wed, 15 Jul 2020 11:14:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7yX4/qpc6jhHsGJ+/oEaNJl+Tn5TEqCo8b8O+Tto8Iax62YVx5mKTcAbJeUiLYJswe/NP X-Received: by 2002:aa7:da58:: with SMTP id w24mr834962eds.385.1594836892282; Wed, 15 Jul 2020 11:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594836892; cv=none; d=google.com; s=arc-20160816; b=QZd3xj0W328DCzlydNxIRXonNmnDs7lnZn/MiCQCzPVecWO0oQ5dKGe8X6eChAEC+d nbJIOSfzXZ5v6S9ymBza3ewYRRYTQX3PahQtquKTDXqhVUIe2i15fzzpn1GPc7KStPpY Yj7qQBbWtnw0e/xnidLQCx5bLN2lOkIBqlfZoGvjatnTZGVzsCIa3E25/UvMWOn1caWS Ur+dkVn37qnX+gW7bygKbJy2aRULO/mZiJyWAIGdQ7CkHQtS0g+a7KkeXxW8ONxOAd96 1xy/0/VTROf1DkIeSgEhEJ5M63JRFc7JW0s9qt1fGjoR/OUSpjBZr/7ZXdj6IYcnCdDU zt0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=saTIUebuHx60grLsqQ5UA1G0XniSO168pvbDAVmqxss=; b=KfQcXSMD7Vo7EUUpsJ9OrLmFfWqVKPpsxvnaoFqR9GtnKfrgocE6A0CjRK5SH1WGpn 5Kj04aqb4DSw6dBpmbf/izISOW+/OO+5YGh9/dNOeRotImwHoJrO+U9QHcViA+ZFgnSF s7LjfvG/WPrYYqwl+OMSfvmT1FZe/LIAo17UIOHvHOHMded/EusgZQxBo+KOFPGfXOqF 5LqemsiiuU+MYeEziDhXAQr0lN2AXrutNofj5QEXja8EBBECRWm+WuMJQG1EJ3Jbqujg zR0J3YVh9CSlvpPuyIRcpv81lNA432xn7WOHqr32PGqZL7HK5fDGogiMe7sO/qWyDk6L VZ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=sin0sp3g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v16si1765655edw.426.2020.07.15.11.14.28; Wed, 15 Jul 2020 11:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=sin0sp3g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbgGOSMI (ORCPT + 99 others); Wed, 15 Jul 2020 14:12:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbgGOSMH (ORCPT ); Wed, 15 Jul 2020 14:12:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93D05C061755; Wed, 15 Jul 2020 11:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=saTIUebuHx60grLsqQ5UA1G0XniSO168pvbDAVmqxss=; b=sin0sp3gxKo1VHxgpXPM0it16z l3hICd/BFK2RVOQxe5HYgHEQNa5xtOc8ZYtYE4CsToJHDbrrwCqG6GHy/AeKiA+8hbiJneuYJw6so nxYIpDv1qzfV2VP0CEYo4Qm4m8wpch2uwyWKJg4qF2HYhA2hvFsd5WqvRpiSHuuucrI8D2K2SY05X bLiumEk5g1+/LfBYpN9LX8muhR7GD3wNPL2ospnqgFD4pU4hyrtlep5i2F1I5app3GYyv1mg9JM/L od2CDDzl4K1T9ytxRoCHA72e5bkqZefTF0pg94y8IHRVfBT1GLq3OrTqRnkfaoYuJJ62W7hQYf8cR d+tFttEQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvlsf-0004ih-GE; Wed, 15 Jul 2020 18:11:45 +0000 Date: Wed, 15 Jul 2020 19:11:45 +0100 From: Christoph Hellwig To: Simon Arlott Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Linux Kernel Mailing List , Jonathan Corbet , linux-doc@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Bart Van Assche , Christoph Hellwig , Damien Le Moal , Pavel Machek , Henrique de Moraes Holschuh Subject: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot Message-ID: <20200715181145.GA17753@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Except for the fact that I think that usage of the BIT() macro is a horrible pattern, this looks good: Reviewed-by: Christoph Hellwig