Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Marius Zachmann <mail@mariuszachmann.de>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: corsair-cpro: Change to HID driver
Date:   Wed, 15 Jul 2020 21:12:55 +0200
Message-ID: <51449356.7lugSRDzgr@marius>
In-Reply-To: <f17c4888-4f5f-0a51-304f-54efd601f00a@roeck-us.net>
References: <20200715151419.43134-1-mail@mariuszachmann.de> <f17c4888-4f5f-0a51-304f-54efd601f00a@roeck-us.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15.07.20 at 17:35:08 CEST, Guenter Roeck wrote
> On 7/15/20 8:14 AM, Marius Zachmann wrote:
> > This changes corsair-cpro to a hid driver using hid reports.
> > 
> > Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>
> > 
> > ---
> 
...
> > -module_usb_driver(ccp_driver);
> > +static int __init ccp_init(void)
> > +{
> > +	return hid_register_driver(&ccp_driver);
> > +}
> > +
> > +static void __exit ccp_exit(void)
> > +{
> > +	hid_unregister_driver(&ccp_driver);
> > +}
> > +
> > +/* make sure it is loaded after hid */
> > +late_initcall(ccp_init);
> > +module_exit(ccp_exit);
> 
> Sorry for not noticing before, but can you use module_hid_driver() ?
> That seems to work for other hid drivers.
> 
> Thanks,
> Guenter
> 

When using module_hid_driver() and compiling the driver as built-in
the driver init function will get called before hid and fail registering
the driver. late_initcall forces it to be loaded after hid.

Greetings,
Marius