Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp717386ybh; Wed, 15 Jul 2020 13:16:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+Ml1uNsuDaSlG7EPbvqZVKnA4juIRIiLo4BpsgJPbyB55LgLxGn7Uz1sHvdn5kPSVITGN X-Received: by 2002:a17:906:27c9:: with SMTP id k9mr656479ejc.74.1594844182004; Wed, 15 Jul 2020 13:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594844181; cv=none; d=google.com; s=arc-20160816; b=PTSDIEBK3cr/KB3EyuHn9IIX+0dZRhvdStCn0lCjjf6vVBFT25ttIU3ryxkNfQLZ2X mC1Ub8g4F91UIzl9eEfWzmexgJO90N5sR+ofueLB4CC7vEG4WiIocZi10keBREKS+Xx7 wmCE8VTgp2z9DGtnz/FpYbqq1jkEo34n1fa5kQjERQFz68GxWrf7Rd6SAk1x+9S8yqD0 iXMQfEHlSxoIlh0zubuYSRR1LLY6xHVKx4leok8x5FJUNyRdv0mzCNqkq0JDxio1OJmp mybK2WQxozRfoRvi8aXQiZKT1Q7kpKGqHLgZwmJ2OWhXnutjnEyx+6wdIXlkLkgO/BY0 zTPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=jYA/oNKDV5tuYlRC12bb44dQzKeSWg1Z+Lr/djLF7Xo=; b=cjVRV4nF5q4nDRaScq3wO1AbpqcM1fuVSPKeAXfY+D9QfRa8B4s1bQqN60VoEF7mIO WL/IkHO0KF/k1ZFWqL4FSKSsTuWEKqdVpCKNrk4rsWNTaStzEsYgtssEdbK7tsbrEyJ6 ndLqvxhUwEV5XQ/xdDTCB1LJAOqiFfNSt9wdQv8zvCl98vW6wYt5mZ8WAKQsrG/yt5ED e7FTNbTtpLXAUwJvLVT9fQ71v/H2Y1nH+/qg88YFir9Go3421OjvPrxppWOOZ+xSPk/Z TAPt7E97aU5l27PT1uZwaDxp1Dk38hCYTl1WNSEvAGgeon/g84WlheRkxIfGv2lybYpU x7vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=NBWTbLiJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si1848387edw.583.2020.07.15.13.15.58; Wed, 15 Jul 2020 13:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=NBWTbLiJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbgGOUPm (ORCPT + 99 others); Wed, 15 Jul 2020 16:15:42 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:39030 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbgGOUPl (ORCPT ); Wed, 15 Jul 2020 16:15:41 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FKCALc035647; Wed, 15 Jul 2020 20:14:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=jYA/oNKDV5tuYlRC12bb44dQzKeSWg1Z+Lr/djLF7Xo=; b=NBWTbLiJ78ctYZAn84xzzyBw9i5TTW+BinidJ4Mfoe6Fx1nyH9QZvHLYSrp6kKI8sKZ0 El7xeqLtQxdayLS1ob/SmYiR/atq8a+3fWQ6Jz80E6zPf6iIJdxUqq/xrN7fpzqzHCW2 NA2Iku9ONLl+ZiDyW5oY3UInGZVcAd8Y1zVQmIUS4n+7gXzNaJ7yvGUKvZyecTDudQZC S7TdOyG9wAGZMS5/pjnkHMP3q1Yh71TLOYKhArpz91MPnq+3hBbZwmeoJ9D9QHtUK058 NjJDUzBPqD/uNuDPmR9d+0JLY3IZDjoqKEIJrNvJZnq1Ki2kyfLuEfglFZM8swALIRzf 2g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 3274urdn2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Jul 2020 20:14:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FKCh4i018101; Wed, 15 Jul 2020 20:14:37 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 327qc1n1tv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jul 2020 20:14:37 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06FKERjY002445; Wed, 15 Jul 2020 20:14:32 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Jul 2020 13:14:27 -0700 To: Christoph Hellwig Cc: Simon Arlott , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Linux Kernel Mailing List , Jonathan Corbet , linux-doc@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Bart Van Assche , Damien Le Moal , Pavel Machek , Henrique de Moraes Holschuh Subject: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot From: "Martin K. Petersen" Organization: Oracle Message-ID: References: <20200715181145.GA17753@infradead.org> Date: Wed, 15 Jul 2020 16:14:23 -0400 In-Reply-To: <20200715181145.GA17753@infradead.org> (Christoph Hellwig's message of "Wed, 15 Jul 2020 19:11:45 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150155 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 impostorscore=0 suspectscore=1 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150155 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > Except for the fact that I think that usage of the BIT() macro is > a horrible pattern, this looks good: > > Reviewed-by: Christoph Hellwig Looks good to me too. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering