Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp737404ybh; Wed, 15 Jul 2020 13:56:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrAdE9hmBc6wi4irOSRDbGX1NY2i1nUUqbtTnFnhsAoz7rhYcMfvtS1qOKdzL4iyKRNFdS X-Received: by 2002:a17:906:2296:: with SMTP id p22mr736341eja.510.1594846577188; Wed, 15 Jul 2020 13:56:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594846577; cv=none; d=google.com; s=arc-20160816; b=WP/V4vQMR+3gKvhus3u8nEwP+7trlJ3aIyRqBQbURn8UmVFolxEwbsjYxhzxJytMwl EZAJ/xBREBgaQ0o1d+0L6SBoZ89R/atjZQFfKy+mVhnXE7FN5W0waWp8vwwIdNIkfA0h owXVBBKXNlnOtH3jvjHuuKEqPfuXyCOR8IbiyHP6YjB7wsCz/+aW/QR6D9Gj3dwKZIeC QtRnK206R1avvPJBWjaQpfg+rAOV33xw8HF0UznUgqQcR1GEjtn3oT3cs7lIzojIQkTz 5ojhv+BfmIhzdyUoxrbClQmiJpYt7faTxOmwdGqzr4dXcB1tcifzNPz7nRdV8+MV6VRq ZNxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=62GDuwaaSfc70sN5qjgMF0+16PJauklzFTdwCeP+NQA=; b=u8iGPpi7Pza9zg8ifSEP6GG4cqQhVmrENByN3XbkozmAcQLET5hOn/UiOWhOhWQVka LiHSgaG1o8QUPgTdD6brpXMCEnaksfFlpxBguEsG7AXRiYo5isngqjg7oPldK82eUg8V d8/RfVkQE4t/NOsWpL4dhewuYJ9VojTjUsciAcyUJ2cJ1Ftf9Av4SjGZvE91fHKZuwGz JoBjzvg93148HgTSVQb3Uyc+siGQekVl/x6Pz0Uk1r24zHT7D0uEafKMzhWP1rwfopvC u3GCcj+537J62rsjbkRMtZdv+xDvkzKBogPdA3Fd6Tv7Muc0hcISHjcy25c5BmAqIKck Gvag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=HDRUmGjV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z65si1923568ede.610.2020.07.15.13.55.53; Wed, 15 Jul 2020 13:56:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=HDRUmGjV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgGOUxp (ORCPT + 99 others); Wed, 15 Jul 2020 16:53:45 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:57780 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726356AbgGOUxo (ORCPT ); Wed, 15 Jul 2020 16:53:44 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FKW2Du147198; Wed, 15 Jul 2020 20:53:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=62GDuwaaSfc70sN5qjgMF0+16PJauklzFTdwCeP+NQA=; b=HDRUmGjVogNoQNaF+paYq4QBogeS4Nvz/WFgY2AlLrnKaRn68pmjTe/94QxXbdL534Wm mOzej0+qFCf/s8EPSOfzAggfn4ikBqaZzn+bBbAfQnduIEDJt7tXibQL52J9rTnVYYB/ xZ5cYOU09PDzkm3jQmhKc4y2PmxflfN6i+UgHrsqLE4cBJRwGBx5sF5o/A/1Crbrkirp hu+omEEhvOgh3SWEuxHMRcAfWwbnqfXWTUWEdzM8+kSdsZIJbX8jh+CCIqCTr3RucH2R RWH0M/TIyduSk2tyBa9sdtBWly3o5sOrYm4LMnArsuAWvCokH8+CtACW3pTempPpKk8+ 2w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 327s65m17y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Jul 2020 20:53:18 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FKXeeZ059197; Wed, 15 Jul 2020 20:53:18 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 327qb8thdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jul 2020 20:53:18 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06FKrHXb031054; Wed, 15 Jul 2020 20:53:17 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Jul 2020 13:53:17 -0700 To: Simon Arlott Cc: Jens Axboe , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Park Ju Hyung , Tejun Heo Subject: Re: [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <9324ef33-eedd-b965-37e8-b82e06778aab@0882a8b5-c6c3-11e9-b005-00805fc181fe> Date: Wed, 15 Jul 2020 16:53:14 -0400 In-Reply-To: <9324ef33-eedd-b965-37e8-b82e06778aab@0882a8b5-c6c3-11e9-b005-00805fc181fe> (Simon Arlott's message of "Wed, 15 Jul 2020 12:13:24 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=921 malwarescore=0 mlxscore=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 phishscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1011 bulkscore=0 mlxlogscore=931 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150158 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon! > Despite the unsubstantiated claim from Samsung that "the improved > queued trim enhances Linux compatibility" this does not appear to be > true, even on Intel SATA controllers: I am aware of several people using 860 drives with queued TRIM. And I haven't heard any complaints outside of the bug you referenced. Also, I have tested both 860 2.5" Pro and 860 mSATA EVO on a few different systems in my lab without any problems. See: https://lore.kernel.org/stable/yq1h87du82d.fsf@oracle.com/T/ I really wish we had some more data to work with :( Lacking a proper heuristic I guess we don't have any choice to disable the feature. But that's sad news for the people who currently don't have problems since their performance will inevitably suffer. -- Martin K. Petersen Oracle Linux Engineering