Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Jul 2020 14:57:51 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     KP Singh <kpsingh@chromium.org>
CC:     <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Paul Turner <pjt@google.com>, Jann Horn <jannh@google.com>,
        Florent Revest <revest@chromium.org>
Subject: Re: [PATCH bpf-next v4 2/4] bpf: Implement bpf_local_storage for
 inodes
Message-ID: <20200715215751.6llgungzff66iwxh@kafai-mbp>
References: <20200709101239.3829793-1-kpsingh@chromium.org>
 <20200709101239.3829793-3-kpsingh@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200709101239.3829793-3-kpsingh@chromium.org>
User-Agent: NeoMutt/20180716
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp (2620:10d:c090:400::5:5ec) by BYAPR03CA0011.namprd03.prod.outlook.com (2603:10b6:a02:a8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Wed, 15 Jul 2020 21:57:52 +0000
X-Originating-IP: [2620:10d:c090:400::5:5ec]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53228ed2-a151-4178-818d-08d8290a1f7f
X-MS-TrafficTypeDiagnostic: BYAPR15MB3302:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3302173FDFDFF84C8FE9E37BD57E0@BYAPR15MB3302.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rkwoy2j2Dqh7bDo/7zPxIsfEZn8/jZq6Ok/7L+5BG7kmNIgzZu4OlOIaltLxt6VbX3GKgggMYPsuIysmaPkn++0GaeB0Mdg0A7ICounkH5vP0Gct9NNCzevZ8Dm0X2YvgJGO11IJ8Ne0swsAB0qaV22z0VCw/9wGXhPncqtAGGscKbzIqB9HV3tlZfwaUHbr8slR5Uo27jSX6bPquz7JdEscPSdQ23FG0gz9SD04HqV2OcQDlphTw8E/CIJK5rk8YCfI0dvc0x7+xgR9IHZCnd242DJuWwieZNzrcqWRJyf0wTJqmrRxFxNkxcvqAIaj
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3571.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(376002)(366004)(136003)(39860400002)(33716001)(16526019)(6496006)(66476007)(52116002)(66556008)(8676002)(66946007)(6916009)(55016002)(186003)(2906002)(5660300002)(478600001)(86362001)(1076003)(4326008)(83380400001)(9686003)(8936002)(54906003)(316002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: RSftEDidlj8JSHfFPGhw1971hlgUmR8XFPJ8VZT5VkY1fkoDiIJ9yOVGTgoNkg6WpONa05YIwe0tbRTXlJAN9M59TeJNixbaw2vwM5NLXGOzdN6NwkXke3naayNCkE+HODdlwENhu1HxLkOHGloE9IP/XAfzLXFFLL+5VHI6kgs8q5LboTF9fvh23PURhF1TOLWaHTUbg10/YoH3zonl1GCHYDk1+QgWcYfvQEeW6XJG+yMy0LyI5ibOha7GDnTdlCyi5eIWA7wjgUQD3sqXh3hahM9gqVAC/yE3qTO93iUFEyHTW4tziP+yKEBHhv+KCHW1HMEP2fCS9MSLCt9JVZ97LqNplyqoVC7wD015Ve+V2alte0c9or/WK7TppwJ6fseWiA9YIZFHtkbKiMYVWPIBazPaIyZIuRJPLJ4GGv99PEE2CdcbYexB1OyMBgOEnl6joaqFsklHrn6mi9tPALsGvQUbYVHrV7sSCmEQGWxIlQt7HGTE+In8riTb4BzqBa9PQkuweO01p7GFyANRxw==
X-MS-Exchange-CrossTenant-Network-Message-Id: 53228ed2-a151-4178-818d-08d8290a1f7f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3571.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2020 21:57:52.9166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A6YOUTlZi2+0gtntqdl59DWWr8NpT8HgM90FACht9Q899jJxO7XR4opesewUxwuS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3302
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-07-15_12:2020-07-15,2020-07-15 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 mlxscore=0
 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=2
 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501
 mlxlogscore=485 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2006250000 definitions=main-2007150163
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 09, 2020 at 12:12:37PM +0200, KP Singh wrote:
> From: KP Singh <kpsingh@google.com>
> 
> Similar to bpf_local_storage for sockets, add local storage for inodes.
> The life-cycle of storage is managed with the life-cycle of the inode.
> i.e. the storage is destroyed along with the owning inode.
> 
> The BPF LSM allocates an __rcu pointer to the bpf_local_storage in the
> security blob which are now stackable and can co-exist with other LSMs.
> 
> Signed-off-by: KP Singh <kpsingh@google.com>

[ ... ]


> +static void *bpf_inode_storage_lookup_elem(struct bpf_map *map, void *key)
> +{
> +	struct bpf_local_storage_data *sdata;
> +	struct inode *inode;
> +	int err = -EINVAL;
> +
> +	if (key) {
> +		inode = *(struct inode **)(key);
The bpf_inode_storage_lookup_elem() here and the (update|delete)_elem() below
are called from the userspace syscall.  How the userspace may provide this key?

> +		sdata = inode_storage_lookup(inode, map, true);
> +		return sdata ? sdata->data : NULL;
> +	}
> +
> +	return ERR_PTR(err);
> +}
> +
> +static int bpf_inode_storage_update_elem(struct bpf_map *map, void *key,
> +					 void *value, u64 map_flags)
> +{
> +	struct bpf_local_storage_data *sdata;
> +	struct inode *inode;
> +	int err = -EINVAL;
> +
> +	if (key) {
> +		inode = *(struct inode **)(key);
> +		sdata = map->ops->map_local_storage_update(inode, map, value,
> +							   map_flags);
> +		return PTR_ERR_OR_ZERO(sdata);
> +	}
> +	return err;
> +}
> +
> +static int inode_storage_delete(struct inode *inode, struct bpf_map *map)
> +{
> +	struct bpf_local_storage_data *sdata;
> +
> +	sdata = inode_storage_lookup(inode, map, false);
> +	if (!sdata)
> +		return -ENOENT;
> +
> +	bpf_selem_unlink_map_elem(SELEM(sdata));
> +
> +	return 0;
> +}
> +
> +static int bpf_inode_storage_delete_elem(struct bpf_map *map, void *key)
> +{
> +	struct inode *inode;
> +	int err = -EINVAL;
> +
> +	if (key) {
> +		inode = *(struct inode **)(key);
> +		err = inode_storage_delete(inode, map);
> +	}
> +
> +	return err;
> +}
> +

[ ... ]

> +static int inode_storage_map_btf_id;
> +const struct bpf_map_ops inode_storage_map_ops = {
> +	.map_alloc_check = bpf_local_storage_map_alloc_check,
> +	.map_alloc = inode_storage_map_alloc,
> +	.map_free = inode_storage_map_free,
> +	.map_get_next_key = notsupp_get_next_key,
> +	.map_lookup_elem = bpf_inode_storage_lookup_elem,
> +	.map_update_elem = bpf_inode_storage_update_elem,
> +	.map_delete_elem = bpf_inode_storage_delete_elem,
> +	.map_check_btf = bpf_local_storage_map_check_btf,
> +	.map_btf_name = "bpf_local_storage_map",
> +	.map_btf_id = &inode_storage_map_btf_id,
> +	.map_local_storage_alloc = inode_storage_alloc,
> +	.map_selem_alloc = inode_selem_alloc,
> +	.map_local_storage_update = inode_storage_update,
> +	.map_local_storage_unlink = unlink_inode_storage,
> +};
> +