Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com>
 <CAHk-=wh4pB-jRngOjcGxpc8=NPds3jWqJwDMUWC3-OEo4dRiKg@mail.gmail.com>
 <20200715205428.GA201569@google.com> <CAHk-=wg-_Oof43pKUHMk4ySdLwpYi7+shFg+aeV18UP2Akiv8g@mail.gmail.com>
 <CAHk-=wg+iVwK7MDXB+BPbhTmP-1eBa-y4vxRNr_G8ETnzv5pZg@mail.gmail.com>
 <20200715222228.jf2pv5u2wyhtc5o5@box> <CAHk-=wgp-ZJ+J250DMaJFBDU2hnhUUqXcUnVnZZ1iFQEK6O-jg@mail.gmail.com>
In-Reply-To: <CAHk-=wgp-ZJ+J250DMaJFBDU2hnhUUqXcUnVnZZ1iFQEK6O-jg@mail.gmail.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 15 Jul 2020 16:04:47 -0700
Message-ID: <CAHk-=wh3jD4dwXWWFors9OnYp-YCzYN2bCGs9HDxrtZ=TiFyDQ@mail.gmail.com>
Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd()
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
Cc:     Joel Fernandes <joel@joelfernandes.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        William Kucharski <william.kucharski@oracle.com>
Content-Type: multipart/mixed; boundary="0000000000003d291905aa82f406"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--0000000000003d291905aa82f406
Content-Type: text/plain; charset="UTF-8"

On Wed, Jul 15, 2020 at 3:57 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> But now I've screwed it up twice, and have a splitting headache, so
> rather than stare at this cross-eyed, I'll take a break and hope that
> somebody more competent than me looks at the code.

I lied. I had a couple of pending pulls, so I couldn't go lie down
anyway, so I tried to take another look.

It *might* be as simple as this incremetal thing on top, but then I
think that code will no longer trigger on the stack movement case at
all, since there we don't work with the whole vma.

So if we want that to work, we'd have to fix that up too.

And this might be broken anyway. My track record isn't looking so hot right now.

                  Linus

--0000000000003d291905aa82f406
Content-Type: application/octet-stream; name="patch.incremental"
Content-Disposition: attachment; filename="patch.incremental"
Content-Transfer-Encoding: base64
Content-ID: <f_kcnz23n30>
X-Attachment-Id: f_kcnz23n30

ZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFwLmMKaW5kZXggNjE0YjRmZmZlZDFk
Li42YzNkZjAyMmZmNjQgMTAwNjQ0Ci0tLSBhL21tL21yZW1hcC5jCisrKyBiL21tL21yZW1hcC5j
CkBAIC0yNDMsNiArMjQzLDkgQEAgc3RhdGljIGlubGluZSB2b2lkIHRyeV90b19hbGlnbl9zdGFy
dCh1bnNpZ25lZCBsb25nICpsZW4sCiAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICpvbGQsIHVuc2ln
bmVkIGxvbmcgKm9sZF9hZGRyLAogCXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqbmV3LCB1bnNpZ25l
ZCBsb25nICpuZXdfYWRkcikKIHsKKwlpZiAoKm9sZF9hZGRyID4gb2xkLT52bV9zdGFydCkKKwkJ
cmV0dXJuOworCiAJaWYgKEFERFJfQkVGT1JFX1BSRVYoKm9sZF9hZGRyICYgUE1EX01BU0ssIG9s
ZCkpCiAJCXJldHVybjsKIApAQCAtMjcwLDYgKzI3Myw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB0
cnlfdG9fYWxpZ25fZW5kKHVuc2lnbmVkIGxvbmcgKmxlbiwKIAlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1
Y3QgKm9sZCwgdW5zaWduZWQgbG9uZyAqb2xkX2FkZHIsCiAJc3RydWN0IHZtX2FyZWFfc3RydWN0
ICpuZXcsIHVuc2lnbmVkIGxvbmcgKm5ld19hZGRyKQogeworCWlmICgqb2xkX2FkZHIgPCBvbGQt
PnZtX2VuZCkKKwkJcmV0dXJuOworCiAJaWYgKEFERFJfQUZURVJfTkVYVCgqb2xkX2FkZHIgKyAq
bGVuLCBvbGQpKQogCQlyZXR1cm47CiAK
--0000000000003d291905aa82f406--