Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1594285927-1840-1-git-send-email-neal.liu@mediatek.com> <1594285927-1840-3-git-send-email-neal.liu@mediatek.com>
In-Reply-To: <1594285927-1840-3-git-send-email-neal.liu@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Thu, 16 Jul 2020 07:46:39 +0800
Message-ID: <CAAOTY_-6d12FUf5XnYco0f0CfeWsb-XjsCESsLixLr_Q=jnc0Q@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver
To:     Neal Liu <neal.liu@mediatek.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        devicetree@vger.kernel.org,
        wsd_upstream <wsd_upstream@mediatek.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

HI, Neal:

Neal Liu <neal.liu@mediatek.com> =E6=96=BC 2020=E5=B9=B47=E6=9C=889=E6=97=
=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:13=E5=AF=AB=E9=81=93=EF=BC=9A
>
> MediaTek bus fabric provides TrustZone security support and data
> protection to prevent slaves from being accessed by unexpected
> masters.
> The security violation is logged and sent to the processor for
> further analysis or countermeasures.
>
> Any occurrence of security violation would raise an interrupt, and
> it will be handled by mtk-devapc driver. The violation
> information is printed in order to find the murderer.
>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---

[snip]

> +
> +/*
> + * mtk_devapc_dump_vio_dbg - shift & dump the violation debug informatio=
n.
> + */
> +static bool mtk_devapc_dump_vio_dbg(struct mtk_devapc_context *devapc_ct=
x,
> +                                   int slave_type, int *vio_idx)
> +{
> +       const struct mtk_device_info **device_info;
> +       u32 shift_bit;
> +       int i;
> +
> +       device_info =3D devapc_ctx->device_info;
> +
> +       for (i =3D 0; i < get_vio_slave_num(slave_type); i++) {
> +               *vio_idx =3D device_info[slave_type][i].vio_index;
> +
> +               if (check_vio_mask(devapc_ctx, slave_type, *vio_idx))
> +                       continue;

I guess if one vio_idx is masked, its status would never be true. If
my guess is right, I think you could skip check_vio_mask() and
directly check_vio_status().

> +
> +               if (!check_vio_status(devapc_ctx, slave_type, *vio_idx))
> +                       continue;
> +
> +               shift_bit =3D get_shift_group(devapc_ctx, slave_type, *vi=
o_idx);
> +
> +               if (!sync_vio_dbg(devapc_ctx, slave_type, shift_bit))
> +                       continue;
> +
> +               devapc_extract_vio_dbg(devapc_ctx, slave_type);
> +
> +               return true;

I think multiple vio_idx would violate at the same time, why just process o=
ne?

Regards,
Chun-Kuang.

> +       }
> +
> +       return false;
> +}