Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp859050ybh;
        Wed, 15 Jul 2020 18:04:25 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxpC3UFF7zpkjXp8KhSuuZ0Rn7Lqp5s6Lo6QN9Bz8e9fMnDttQLJDW2wrENy5ya7+gbmqzr
X-Received: by 2002:a17:906:e089:: with SMTP id gh9mr1510037ejb.482.1594861464909;
        Wed, 15 Jul 2020 18:04:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594861464; cv=none;
        d=google.com; s=arc-20160816;
        b=050ij8vIbsIqajOaLbtD7RXo0k7lEZy8PrfymRFklPh0FsUzlyUKwzBLx1qIehJvjf
         ZBfMfXplOj2vUFzA8Fmpsdk5MorBbZTZPZqbUdj3mhT8ByCJnywyYPIxouhDsEKZuH0n
         QpuExyETEVNXZsCdiPcZNUnCzijPb5s0joOnBUU2NUNRfAR9NH2/vqJ3ezaPZZuKtCD8
         In1dp0s0wBKxvg5BMYGYS6Cn7p2+QhMa/P5T5ZR9mj8KD6hMl2K2NYxYG0f72MJYwoAP
         p/VRFtIuCKudzo5RNzMMQOxbeEO7S4pOtypiWbcL8AX7/tAYEC1xstAcga2D2kCopajq
         j6qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=vT2lenIF2RLpve1XAObLmLMSGrXRckg7Pc5aiN56au0=;
        b=ks9LIAyQVxB8e9EAn1WqTtV0PSn+34D6wdFn+zTg6a9M8MBm4bGwPKB5JiozKljy55
         J5i/4aMxs/CKT3IOLL18OWsCaRF4RqVief/jq797H8lTQmnZryxvlte8l8nOH20jwkXw
         Hbf83Rn6xZXaQswca9y0m4P9Z6z48aCM6lGKyfY1CnB9d+7UkjWPw4uedekR9tk++CL9
         JO16He/vE+1XRXHWgTElmKgC7A7VGwhi6dTkDnEPMBWUox/aQbPx+SIrn5wp+FBzLvKw
         qovzMeVo4A0TrF8YcsrsiYUbb8qLpYpxos01B3lVwUEtJ2dXLALDDxEjpT9P1FUpNufI
         PL0g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=QSv1YLr1;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id cy5si2248423edb.554.2020.07.15.18.04.01;
        Wed, 15 Jul 2020 18:04:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=QSv1YLr1;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727810AbgGPBBq (ORCPT <rfc822;lunatang2017@gmail.com>
        + 99 others); Wed, 15 Jul 2020 21:01:46 -0400
Received: from mail.kernel.org ([198.145.29.99]:37218 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726479AbgGPBBq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Jul 2020 21:01:46 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id CADCD2078C;
        Thu, 16 Jul 2020 01:01:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1594861306;
        bh=H0H1cfpKnnKuRaYYxUYCzxKrgJeczTSwegc9TcO0VAs=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=QSv1YLr1usVlJCw6XJOYCwZrbBpoj49kSi0E7j03zq9o84atnIeHjJEBjoM6hbFtR
         dIr4hDDPgdHhGE6HzJp1ys9PZHDacnckoeShXBvXqxNQq2tjSAoXUrY5ks5BuqkdBL
         NE8V+XPYjeFo40cdmba3AVHi/zaDUCps0R127rjA=
Date:   Wed, 15 Jul 2020 18:01:44 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Paolo Pisati <paolo.pisati@canonical.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: ip_defrag: modprobe missing
 nf_defrag_ipv6 support
Message-ID: <20200715180144.02b83ed5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200714124032.49133-1-paolo.pisati@canonical.com>
References: <20200714124032.49133-1-paolo.pisati@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Jul 2020 14:40:32 +0200 Paolo Pisati wrote:
>  #
>  # Run a couple of IP defragmentation tests.
>  
> +modprobe -q nf_defrag_ipv6
> +
>  set +x
>  set -e
>  

Any reason you add this command before set -e ?

It seems we want the script to fail if module can't be loaded.