Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20200713010001.18976-4-akshu.agrawal@amd.com>
References: <20200713010001.18976-1-akshu.agrawal@amd.com> <20200713010001.18976-4-akshu.agrawal@amd.com>
Subject: Re: [PATCH 4/5] clk: x86: Support RV architecture
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     akshu.agrawal@amd.com
Date:   Wed, 15 Jul 2020 18:03:16 -0700
Message-ID: <159486139638.1987609.10837351469119432355@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Akshu Agrawal (2020-07-12 17:59:52)
> There is minor difference between previous family of SoC and
> the current one. Which is the there is only 48Mh fixed clk.
> There is no mux and no option to select another freq as there in previous.
>=20
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
> ---

I only see four out of five patches and there isn't a cover letter. I
have no idea if I can apply this change or if you're expecting me to ack
it. Please help make my life a little easier!

>  drivers/clk/x86/clk-fch.c | 55 ++++++++++++++++++++++++++++-----------
>  1 file changed, 40 insertions(+), 15 deletions(-)
>=20
> diff --git a/drivers/clk/x86/clk-fch.c b/drivers/clk/x86/clk-fch.c
> index b252f0cf0628..a8aac71a3b65 100644
> --- a/drivers/clk/x86/clk-fch.c
> +++ b/drivers/clk/x86/clk-fch.c
> @@ -61,9 +78,17 @@ static int fch_clk_probe(struct platform_device *pdev)
>  static int fch_clk_remove(struct platform_device *pdev)
>  {
>         int i;
> +       struct fch_clk_data *fch_data;
> +
> +       fch_data =3D dev_get_platdata(&pdev->dev);
> =20
> -       for (i =3D 0; i < ST_MAX_CLKS; i++)
> -               clk_hw_unregister(hws[i]);
> +       if (!fch_data->is_rv) {
> +               for (i =3D 0; i < ST_MAX_CLKS; i++)
> +                       clk_hw_unregister(hws[i]);
> +       } else {
> +               for (i =3D 0; i < RV_MAX_CLKS; i++)
> +                       clk_hw_unregister(hws[i]);

Can ST_MAX_CLKS or RV_MAX_CLKS be a local variable and then the loop
consolidated.