Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp869585ybh; Wed, 15 Jul 2020 18:25:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3REwi0HAAcbsC6InGKrMUCjMnB2Xyh5/9+EEO4YXTURao705ogXMSwnKKtCmc6rImDHC8 X-Received: by 2002:a17:906:2a5b:: with SMTP id k27mr1596892eje.82.1594862717686; Wed, 15 Jul 2020 18:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594862717; cv=none; d=google.com; s=arc-20160816; b=YYgMcc9v5GvF4/kqfvG4HEmG7yGOOalFBJFS36f1r7GWFLcvcbSdn+d17xVSjM6Y/1 ZACkt77h+p6Xmluu89mvLtbzKBVRkTSCWHSUFIbTt9dvy/mXrdn/lzQSVAHQx0ncunMu TKUT8+4LQicesDD1EMgP52/cemhDtunxbhXXFzBvxD9RKTHemlxvDVfdJwmEjvh/4JTZ eitQWMu0hC6lXSz/ZX1VI9CdWkfv/9jbDshIbqsWkdhkgnvzu3K+E5VowS8bV2e2yrLv dZgXqpjfwqnB9J12ZH4M9N54OmXTvcOuWZIyfKlbSUhDZIHN2PXu34xhWC/avCA1l8gJ nr5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=dDX1L5XjDb2eHGUfpWe1tSm+lPvDYEfgRhobXae+CSg=; b=r+ftBdE0yndyzAj0saLIp0fx5dsLC5N3bNIDJxFLuewx/KEgyh2euzvwBHoRjuV19Y 3gPxcVNsz/Wkx2SMF0ogs2oHiLuZi/YfV9uTpnYYnyebSc3svMIXJ9wK/lkSLMPZSg2b 4ti2ZpgkRpHm0Y+r+sVoeSjCVs5X3eigIwQQhrkGGry9FHCOXetP/i++jm2Os/JQsdU+ rAuW51+XXsxGDuCe2xlafHXUdBU8URC7hHLUwpi8oDkTRn+YhWz5YV0qCk6HpCLaXnln N6fQ/5wsZIbwB2p/y0noh+um9joMYqhD4QuO+193ldrxzPAYhL5IWppe082RP8d0Hc1R 82HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SHkg50mh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si2283819eds.283.2020.07.15.18.24.55; Wed, 15 Jul 2020 18:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SHkg50mh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbgGPBYI (ORCPT + 99 others); Wed, 15 Jul 2020 21:24:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbgGPBYI (ORCPT ); Wed, 15 Jul 2020 21:24:08 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34F0220775; Thu, 16 Jul 2020 01:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594862648; bh=dDX1L5XjDb2eHGUfpWe1tSm+lPvDYEfgRhobXae+CSg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=SHkg50mhZFVxz1ZaSvVhxg13f15nMzWP/EZ73ZE3XvBG5hinHrzJlMkRmBKywkv1K GLuY9oMChmw//sSDOCd+NsbsCHdr7GnD/KfnOCGIvXb6xIEdtx+JiiToZKglNR+dfn 1+Ek1Wi+tN5gQd2yvfoadUJ2xN+7QFQRpJT/qt2Q= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <15ed3803e04699017c6a7909a8df83c215135a89.1594717630.git.rahul.tanwar@linux.intel.com> References: <15ed3803e04699017c6a7909a8df83c215135a89.1594717630.git.rahul.tanwar@linux.intel.com> Subject: Re: [PATCH v1] clk: intel: Address pending review concerns From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, rahul.tanwar.linux@gmail.com, Rahul Tanwar To: Rahul Tanwar , linux-clk@vger.kernel.org, mturquette@baylibre.com Date: Wed, 15 Jul 2020 18:24:07 -0700 Message-ID: <159486264757.1987609.4166237347048554216@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rahul Tanwar (2020-07-14 02:11:44) > Use devm_clk_hw_register() instead of clk_hw_register(). > Remove unnecessary locking. Avoid memset by improving code. Please make a better subject. Also should probably be split into multiple patches and then making a subject will be easier.