Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp927524ybh; Wed, 15 Jul 2020 20:43:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF7K17JeX7m3VHDiASsoSAp9Y2CtJudnVMYi5A/b3CFilUMR1OTytC21oFUAYzl5l+ai8/ X-Received: by 2002:a17:907:426c:: with SMTP id nx20mr1919803ejb.548.1594871034853; Wed, 15 Jul 2020 20:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594871034; cv=none; d=google.com; s=arc-20160816; b=kANMQxYJwmM/NDRVNJ1gxzZW8IHUx1j/cI2QspEKbR1eEfYYfhHU5nV1iJSTQaI+/3 AfOFGFQ4vYJopnFzwzUeVjybdiTnAmWpvDC1hszt5or5RlH1T6YBpjqabjMzl6bQfIJy dVvNRAFvMV9rknEdoelmwOiT0SHt+52bhViJAhS+VKUAAllRvU+FB3R1wtiqF+LNC8D9 z9xLMFa46Cl0NJzxquz6gsj9eZj6pt5Isw1Q3dJ9Ce3yotcJQebLayNAN9jyCnOubBJD 4nPi+cfB1FXivAPq4sinIQtxFmjdTG7LH9OLdaAzdyW3GdeO7BTKUwhtTe14aEfmLg9r UsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=+TagprwvmXSc1N0W5FclS2rhNYT7VW3JX7kAs8Swwvc=; b=kNzmNMUadUfDmVT6iiJqT5xQkssm9oTUr0R13U8pSjMNj0+T0YJdz947PCDZCMVLHt D3OEPODsE4RyCjVVKba/yrijwyEV6GlVeewmpxixE2IMiBwirm8z6Si938CJw89ATm5A AjylnM31muZGlFWdIRUJ6iH1NVrelpJyqCQe1XjS2tg4pAyGHJMLZMYjfdlLplmQcZc9 HnJmQUfoVhzoXzal4aKj8yJvijXNnkmt0+chq4d2TvWYshQ/FANeC4rXI9IWLs5FBWgF 6Ol/cNFAXQ8GXC4Q6EXrcO+G/1X3awyqtrX6gB0P4SN5ROFf998DwGzzDl2ByFs18jgB Z+Tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si2431640ejf.12.2020.07.15.20.43.32; Wed, 15 Jul 2020 20:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbgGPDmP (ORCPT + 99 others); Wed, 15 Jul 2020 23:42:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:4816 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728186AbgGPDl0 (ORCPT ); Wed, 15 Jul 2020 23:41:26 -0400 IronPort-SDR: HYc92FVHkzdoU3kZkvURreaT/1L/oNnK78BOs+9CabgthWF7fYqS+Jl9Z7EXENygevI1Rea7Kz CDXxhPeizmSQ== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="137442916" X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="137442916" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 20:41:25 -0700 IronPort-SDR: Hhg21qXorTqd7pdCJjQNZprUA6QK5YopRJWCrDf/myOsck9/q0ocyse/gMhkLgaQHewOfk63z7 whqcIhKCuYxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="316905487" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.152]) by orsmga008.jf.intel.com with ESMTP; 15 Jul 2020 20:41:24 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/9] KVM: VXM: Remove temporary WARN on expected vs. actual EPTP level mismatch Date: Wed, 15 Jul 2020 20:41:19 -0700 Message-Id: <20200716034122.5998-7-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716034122.5998-1-sean.j.christopherson@intel.com> References: <20200716034122.5998-1-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the WARN in vmx_load_mmu_pgd() that was temporarily added to aid bisection/debug in the event the current MMU's shadow root level didn't match VMX's computed EPTP level. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 244053cff0a3a..da75878171cea 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -3072,14 +3072,6 @@ static int vmx_get_tdp_level(struct kvm_vcpu *vcpu) return 4; } -static int get_ept_level(struct kvm_vcpu *vcpu) -{ - if (is_guest_mode(vcpu) && nested_cpu_has_ept(get_vmcs12(vcpu))) - return vmx_eptp_page_walk_level(nested_ept_get_eptp(vcpu)); - - return vmx_get_tdp_level(vcpu); -} - u64 construct_eptp(struct kvm_vcpu *vcpu, unsigned long root_hpa, int root_level) { @@ -3104,8 +3096,6 @@ static void vmx_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long pgd, u64 eptp; if (enable_ept) { - WARN_ON(pgd_level != get_ept_level(vcpu)); - eptp = construct_eptp(vcpu, pgd, pgd_level); vmcs_write64(EPT_POINTER, eptp); -- 2.26.0