Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1594871563-30088-1-git-send-email-shengjiu.wang@nxp.com> <87sgds2ixs.wl-kuninori.morimoto.gx@renesas.com>
In-Reply-To: <87sgds2ixs.wl-kuninori.morimoto.gx@renesas.com>
From:   Shengjiu Wang <shengjiu.wang@gmail.com>
Date:   Thu, 16 Jul 2020 12:49:02 +0800
Message-ID: <CAA+D8ANH082mozu+SSsQShAzpfF8=vm_tgyPe0gERb4JsJ-sqw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     Shengjiu Wang <shengjiu.wang@nxp.com>,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>,
        ranjani.sridharan@linux.intel.com, Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Shengjiu
>
> > Add missed return for snd_soc_pcm_component_mmap, otherwise it always
> > return -EINVAL.
> >
> > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
>
> Oops, indeed.
> Thank you for the patch.
>
> But it seems these functions are also missing "return"
>         snd_soc_pcm_component_new()
>         snd_soc_pcm_component_sync_stop()
>
> Can you please care these, too ?
Ok, will send v2

best regards
wang shengjiu