Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp995487ybh; Wed, 15 Jul 2020 23:31:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx04GTyPp8mdFP0Z0uuMZvhpjw8dDGkBdgTxQtWroRT0YwT6L4zq2yWxMm4EcUjWfCuV7eX X-Received: by 2002:a17:907:2170:: with SMTP id rl16mr2455874ejb.422.1594881075979; Wed, 15 Jul 2020 23:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594881075; cv=none; d=google.com; s=arc-20160816; b=TcaU/3038J92NRADO+CjPozWbiYPr/t8+KFKers32qFwzdiWSy2ySKqtkvcffrtZ3t yTGJpgbvYXqcAmFc3g0Fb0CN/EyqaLRbei6/biZRHJNA/I4M2e9zDP/3JYNikgK5hjp+ +RHB8ddH+V+77cTLHs3piLDSO8/aOlv8eK9+beBkIgdWBYLGWxZApoX95dtJyW/82OKN 46dxPpvNEy0QN7q6z7r3ic1wgSWnbuL5kVOHw1WDPuLT9Vi6mplnlJI2FjEnxXsf7YJN aRXnHXMBLgvIDn3EmWeIu3bvuB7CJ94ozpenDPJ7bpgrnEDMRAYOTty5kSIJ/UWziZXx C82w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=h2AJ/Po1GziXC50cuzshjtUzPROwPqr6PX0gVpskvZ4=; b=og6h+rSBK4qFEPTn1fPKIQMln9RIxn25/xx9EULs8/xVEWV1J/f5hBi9U0GHxVNdUa BzxvT8k/9VB93MRqgMq3awcHxr9CK2Jg4x00Bd6HiWZSCuzkVsERzPKLrb9i0OJCvJGm 9y0sra9LwiIYs+YYWcgy3z73JjU1bpYN3X7P6CORSZHgoorOHYZCg08GNl7jhIGvekzm 1kLN7w94jz8xUIAacpmM3ZdiFKYF50CsevlO1j8jqXX8Addktr6PBWrOFOl2iTTT7Eh4 8VP9mzd+h83aUPEfaXR0n6YzpK6ICz2CePXn4eJiXY77UvopeomLHfNqRdzc8gkR+dBv m9ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s23si2510259eju.242.2020.07.15.23.30.53; Wed, 15 Jul 2020 23:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbgGPGaj (ORCPT + 99 others); Thu, 16 Jul 2020 02:30:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:43366 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbgGPGai (ORCPT ); Thu, 16 Jul 2020 02:30:38 -0400 IronPort-SDR: jVHbbEHJkM3Xt816+fmHunR4OXEih/z3JD3Jf985At9edlccRbZpaOii5+on2bR8RMusOufHno nVLRNGoX97wA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="146839348" X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="146839348" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 23:30:38 -0700 IronPort-SDR: D8J6wRg5tZG+0hXVNjp5mwySZxVxNo9S/DBrHfYM/jVX/S6Bof9gv0UX7a8uz1z3Jaezgum1DB kM7OsNhvYtrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="308520128" Received: from sgsxdev001.isng.intel.com (HELO localhost) ([10.226.88.11]) by fmsmga004.fm.intel.com with ESMTP; 15 Jul 2020 23:30:35 -0700 From: Rahul Tanwar To: sboyd@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, rahul.tanwar.linux@gmail.com, Rahul Tanwar Subject: [PATCH v2 1/3] clk: intel: Use devm_clk_hw_register() instead of clk_hw_register() Date: Thu, 16 Jul 2020 14:30:30 +0800 Message-Id: <7ef7009b4e9f986fd6dfbf487c0e85de68a4ba9b.1594880946.git.rahul.tanwar@linux.intel.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To ensure that clks are unregistered in case of any failure, use devm_clk_hw_register() instead of clk_hw_register(). Signed-off-by: Rahul Tanwar --- drivers/clk/x86/clk-cgu-pll.c | 2 +- drivers/clk/x86/clk-cgu.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/x86/clk-cgu-pll.c b/drivers/clk/x86/clk-cgu-pll.c index c03cc6b85b9f..3179557b5f78 100644 --- a/drivers/clk/x86/clk-cgu-pll.c +++ b/drivers/clk/x86/clk-cgu-pll.c @@ -128,7 +128,7 @@ lgm_clk_register_pll(struct lgm_clk_provider *ctx, pll->hw.init = &init; hw = &pll->hw; - ret = clk_hw_register(dev, hw); + ret = devm_clk_hw_register(dev, hw); if (ret) return ERR_PTR(ret); diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c index 56af0e04ec1e..88ebeb53b109 100644 --- a/drivers/clk/x86/clk-cgu.c +++ b/drivers/clk/x86/clk-cgu.c @@ -119,7 +119,7 @@ lgm_clk_register_mux(struct lgm_clk_provider *ctx, mux->hw.init = &init; hw = &mux->hw; - ret = clk_hw_register(dev, hw); + ret = devm_clk_hw_register(dev, hw); if (ret) return ERR_PTR(ret); @@ -247,7 +247,7 @@ lgm_clk_register_divider(struct lgm_clk_provider *ctx, div->hw.init = &init; hw = &div->hw; - ret = clk_hw_register(dev, hw); + ret = devm_clk_hw_register(dev, hw); if (ret) return ERR_PTR(ret); @@ -361,7 +361,7 @@ lgm_clk_register_gate(struct lgm_clk_provider *ctx, gate->hw.init = &init; hw = &gate->hw; - ret = clk_hw_register(dev, hw); + ret = devm_clk_hw_register(dev, hw); if (ret) return ERR_PTR(ret); @@ -624,7 +624,7 @@ int lgm_clk_register_ddiv(struct lgm_clk_provider *ctx, ddiv->hw.init = &init; hw = &ddiv->hw; - ret = clk_hw_register(dev, hw); + ret = devm_clk_hw_register(dev, hw); if (ret) { dev_err(dev, "register clk: %s failed!\n", list->name); return ret; -- 2.11.0