Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 02/10] media: uapi: h264: Further clarify scaling lists
 order
To:     Ezequiel Garcia <ezequiel@collabora.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Tomasz Figa <tfiga@chromium.org>, kernel@collabora.com,
        Jonas Karlman <jonas@kwiboo.se>,
        Alexandre Courbot <acourbot@chromium.org>,
        Jeffrey Kardatzke <jkardatzke@chromium.org>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Maxime Ripard <mripard@kernel.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>
References: <20200715202233.185680-1-ezequiel@collabora.com>
 <20200715202233.185680-3-ezequiel@collabora.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <bfb5d0df-779f-78d2-fc48-3c6056f5fdd3@xs4all.nl>
Date:   Thu, 16 Jul 2020 09:23:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200715202233.185680-3-ezequiel@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15/07/2020 22:22, Ezequiel Garcia wrote:
> Commit 0b0393d59eb4a ("media: uapi: h264: clarify
> expected scaling_list_4x4/8x8 order") improved the
> documentation on H264 scaling lists order.
> 
> This commit improves the documentation by clarifying
> that the lists themselves are expected in matrix order.

"matrix order" is not a well defined term. Especially since different
programming languages lay out matrices differently (e.g. fortran uses
column-major order). Perhaps something like this is more unambiguous:

"The values on each scaling list are in row-major order."

BTW, why not be explicit and use:

__u8 scaling_list_4x4[6][4][4];
__u8 scaling_list_8x8[6][8][8];

That makes it explicit and the order is just that of what the C language
uses.

Regards,

	Hans

> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> index c2e17c02f77e..16bfc98ab2f6 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> @@ -1725,12 +1725,14 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
>        - ``scaling_list_4x4[6][16]``
>        - Scaling matrix after applying the inverse scanning process.
>          Expected list order is Intra Y, Intra Cb, Intra Cr, Inter Y,
> -        Inter Cb, Inter Cr.
> +        Inter Cb, Inter Cr. The values on each scaling list are
> +        expected in matrix order.
>      * - __u8
>        - ``scaling_list_8x8[6][64]``
>        - Scaling matrix after applying the inverse scanning process.
>          Expected list order is Intra Y, Inter Y, Intra Cb, Inter Cb,
> -        Intra Cr, Inter Cr.
> +        Intra Cr, Inter Cr. The values on each scaling list are
> +        expected in matrix order.
>  
>  ``V4L2_CID_MPEG_VIDEO_H264_SLICE_PARAMS (struct)``
>      Specifies the slice parameters (as extracted from the bitstream)
>