Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1018770ybh;
        Thu, 16 Jul 2020 00:24:08 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzPwHVOL5lAJh5S2s1QpCLyJYR67zHLYfzUpeM1xY4NdixUUubYid4nA9I1TkMaiNWye9o4
X-Received: by 2002:aa7:d693:: with SMTP id d19mr3327645edr.317.1594884247862;
        Thu, 16 Jul 2020 00:24:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594884247; cv=none;
        d=google.com; s=arc-20160816;
        b=Y7Nyk7dom2i1nru0U4IWt45DF3AfHhh/eMnfaJye7fvZLL7ybrr/ALV3FsmLCgqDb+
         JIenThf8wHHXUlZ+liaiAdPjyjGFzKc4i+R08Z8Kdd2xLh8X9g0KDzic6EO3pJP1tJIr
         3+Hv2UePYDuutvI51LruYkETeuqkYA9s0lKpeX+LeT1KKRO1Wi8a/10r0yxwae+IQ57J
         G6Sp9ThwAijegUz1WGwYbSRejUn6b+jzcomI9zxfiUjB9Jqp2y+6SmUO594Hz+UF6/7s
         GOVAu6k4XbjfAUPAYtYR9rXKLniCRBsyq4zcP27t6K2CgqM/xwWBIg/Gl2n72c0bW/S/
         20cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version;
        bh=4VmvjZDsnQSCsnAdrtuni5GNCSEbuCmNLcMY3wa2Le0=;
        b=sMe5oo5CteE5EI70/gMXCFR0L3dj2FEW4SOf7XwV0JwhoOyeQonW0aV0WmmZALgg7H
         95bKFfEvcpYUA9nXw2+4DBtd1yp1DQrlC269Y1n8Ej51aandf0r/Fqsl9nZPxqesWVsv
         whzE6m3EC+i8PobBVmoVsiiy9L2XL18HyirE/s4GQ9enPwq4Oj3LJOMxNtvKbr+Q2B4c
         x8NxTDD/DnVQ+CubBWtqbzDSrr4GXwizVrOUhhYZg8/DVYZSJal8L083hgKHPx1fIwAB
         2IVwy+CI5BsksgU011VKKVRgmhKYQgetSSa5/h2h2d2Ep+Xm0lb9CT1qlAiVI/RZLtFm
         EBBg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id cz9si2705214edb.530.2020.07.16.00.23.45;
        Thu, 16 Jul 2020 00:24:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728293AbgGPHX1 (ORCPT <rfc822;lunatang2017@gmail.com>
        + 99 others); Thu, 16 Jul 2020 03:23:27 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:47491 "EHLO
        youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726069AbgGPHX0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Jul 2020 03:23:26 -0400
Received: from mail-vs1-f72.google.com ([209.85.217.72])
        by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
        (Exim 4.86_2)
        (envelope-from <paolo.pisati@canonical.com>)
        id 1jvyEm-00048z-FZ
        for linux-kernel@vger.kernel.org; Thu, 16 Jul 2020 07:23:24 +0000
Received: by mail-vs1-f72.google.com with SMTP id h1so843533vsk.2
        for <linux-kernel@vger.kernel.org>; Thu, 16 Jul 2020 00:23:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=4VmvjZDsnQSCsnAdrtuni5GNCSEbuCmNLcMY3wa2Le0=;
        b=q+TbdSrYoZZ6HHvEyO2sOWiqToh8zwJkwlXnKoGuAkesuOrgWI55Q1Enz/NhL6Aj0x
         ChK2omhVxOM+A4ZWfEmM7aC491X3XxwqVPAqtTHYs7fzUPOprAjOJrDuI28zY7XPj1Td
         q6h8UyBXTkZDkvt+CMh+g2QDA6AmYBMmeUtJnWdDEo3L+jXDn/D/pL2Opt5MHQ1vO8+y
         0knpLT8GwFF8taMSBXNvgZHifBn+s/GHY7Y3p1iuzPsqOhNGHo1T5Z2mDW/8FigllfHY
         byyMf5e+RCGbqUU+iAP5FU7LY/hscNfT9e8obDDAxR2nztd/HeYbQMiQbLVa2naVeJ6t
         DwWw==
X-Gm-Message-State: AOAM530oi3yjdUzlYK2ZEtVQXirCiuQrEDwQXb4xe1cmwUGsjFQa0/J7
        nS/abdxbbOY2DEVcNGhZP2So1ATheOxKg6W2NfViFQUWqZATGwDLFBt4bDkIWwfuOBD1o3T2Wtx
        KTmvqdc4PJhILwrdY18jFNe0t3ie4R6rKxnTUNe3K1MghA7+0vi6P9Vobjg==
X-Received: by 2002:a67:ea92:: with SMTP id f18mr2022730vso.223.1594884203580;
        Thu, 16 Jul 2020 00:23:23 -0700 (PDT)
X-Received: by 2002:a67:ea92:: with SMTP id f18mr2022712vso.223.1594884203322;
 Thu, 16 Jul 2020 00:23:23 -0700 (PDT)
MIME-Version: 1.0
References: <20200714124032.49133-1-paolo.pisati@canonical.com> <20200715180144.02b83ed5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200715180144.02b83ed5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Paolo Pisati <paolo.pisati@canonical.com>
Date:   Thu, 16 Jul 2020 09:23:12 +0200
Message-ID: <CAMsH0TQLKba_6G5CDpY4pDpr_PWVu0yE_c+LKoa+2fm2f4bjBQ@mail.gmail.com>
Subject: Re: [PATCH] selftests: net: ip_defrag: modprobe missing
 nf_defrag_ipv6 support
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 16, 2020 at 3:01 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Any reason you add this command before set -e ?
>
> It seems we want the script to fail if module can't be loaded.

Cause if CONFIG_NF_DEFRAG_IPV6=y, the script would unnecessarily fail.

-- 
bye,
p.