Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1594717754-25428-1-git-send-email-zhangqing@loongson.cn> <20200714094406.GA4900@sirena.org.uk>
In-Reply-To: <20200714094406.GA4900@sirena.org.uk>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 16 Jul 2020 11:14:04 +0200
Message-ID: <CAMuHMdUDYpAvy3NLQGjM62pW35gorac7KZn3E9JnjSvREm5K0Q@mail.gmail.com>
Subject: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
To:     Mark Brown <broonie@kernel.org>
Cc:     Qing Zhang <zhangqing@loongson.cn>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Tiezhu Yang <yangtiezhu@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 14, 2020 at 11:45 AM Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jul 14, 2020 at 05:09:14PM +0800, Qing Zhang wrote:
> > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> > calls as required by common clock framework.
> >
> > Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> > ---
> >  drivers/spi/spi-coldfire-qspi.c | 4 ++--
>
> Are you sure that ColdFire uses the common clock framework?

Should be fine, as per include/linux/clk.h:

    #ifdef CONFIG_HAVE_CLK_PREPARE
    int clk_prepare(struct clk *clk);
    int __must_check clk_bulk_prepare(int num_clks,
                                      const struct clk_bulk_data *clks);
    #else
    static inline int clk_prepare(struct clk *clk)
    {
            might_sleep();
            return 0;
    }

    static inline int __must_check
    clk_bulk_prepare(int num_clks, const struct clk_bulk_data *clks)
    {
            might_sleep();
            return 0;
    }
    #endif

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds