Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE
To:     Qinglang Miao <miaoqinglang@huawei.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
References: <20200716084714.7872-1-miaoqinglang@huawei.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <801e6d49-9bd5-8079-bb83-9f67591a9158@huawei.com>
Date:   Thu, 16 Jul 2020 10:25:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20200716084714.7872-1-miaoqinglang@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 16/07/2020 09:47, Qinglang Miao wrote:

Not sure why you cc Greg, but SCSI maintainers should have been - James 
and Martin

> From: Yongqiang Liu <liuyongqiang13@huawei.com>
> 
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>

The sender is not the author, so your signed-off-by should also be here 
(after sign off from Yongqiang Liu)

> ---
>   drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++------------------------
>   1 file changed, 10 insertions(+), 127 deletions(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 852d2620e..f50b0c78f 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -2870,19 +2870,7 @@ static int hisi_sas_debugfs_global_show(struct seq_file *s, void *p)
>   	return 0;
>   }
>   
> -static int hisi_sas_debugfs_global_open(struct inode *inode, struct file *filp)
> -{
> -	return single_open(filp, hisi_sas_debugfs_global_show,
> -			   inode->i_private);
> -}
> -
> -static const struct file_operations hisi_sas_debugfs_global_fops = {
> -	.open = hisi_sas_debugfs_global_open,
> -	.read_iter = seq_read_iter,
> -	.llseek = seq_lseek,
> -	.release = single_release,
> -	.owner = THIS_MODULE,
> -};
> +DEFINE_SHOW_ATTRIBUTE(hisi_sas_debugfs_global);

I couldn't see an equivalent for file_operations which have a read and 
write method, and the driver has a few of those.

Thanks