Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1096753ybh; Thu, 16 Jul 2020 03:05:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUiiLfpBVW1uMeRWMMsQIwltLW7L3BEFi4WDr/pppqJaOTytN7UpwUkR2gl+BPy7zuKXBk X-Received: by 2002:a05:6402:319b:: with SMTP id di27mr3781575edb.133.1594893947966; Thu, 16 Jul 2020 03:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594893947; cv=none; d=google.com; s=arc-20160816; b=fG74em0v2Uf1AJ5DD3wYIbgtnsUXcPlIfmJZfnDj5jVDgKIhaPE8j4FDeynsKUsHoN usCZyvpTsYB+J+QYkkPUVvYiFHozDktxfAbr5VKRN9pScet2UO+OyP1G8vxCfCumy9WV wFYEgVsHJ/QWzl3Vu3Z7VP5ZqS4aA+hF1NVfuHIQjRUn849kQ1AeVLu6cs0BJwx5bNie R8o2wWGaUsRop3uSIVo32dFiMCjrZyvNmYbjyYYeWqGcGIUKfdg4ZVzgKkiACnJwNAJi 1iEx+VDJlPQM+td+D7pEu3nAXed89gQgLoFmKS5R2yl5BDD+OEfikxo29zLl8WR+0QEI 4iAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rfojoeIYRJ8goHEOplk1fYhNVBf3JqzZmmm8/FfP58o=; b=PXppKkJ0+AOhVkVQo0VJdFZKzq1UdjqkbCLLFjpGYs+LCIn162WG+aqdzTvr4e23+s a6UyRfWf5Y0OJ9xZotdc1rAIMd9lfYO6+qavqJtaJeBb+dkpcQV7gEc/SKxqOKMd+gq1 8sXQx2MbNgMDiCwjDS3HGBG1ZssMKr1B/UZEAiq74B/B4mQt9mel5x+lrj9XeV5b+bRl ogz6MCigtLpGszs3Z7ILXg33mwwyTUJNCLs5WIncZQhv7oG1kbRKt8iDyBdKdmaqw5Ve sjBeIhT5To49vLwwZumYayE6oeK8DigxFHmxJprun9zILu0l9CZj8q51QSpJ/tIK4zJB T2cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si3128272eje.247.2020.07.16.03.05.24; Thu, 16 Jul 2020 03:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727096AbgGPKB5 (ORCPT + 99 others); Thu, 16 Jul 2020 06:01:57 -0400 Received: from elvis.franken.de ([193.175.24.41]:38164 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgGPKB5 (ORCPT ); Thu, 16 Jul 2020 06:01:57 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jw0iB-0008Mc-02; Thu, 16 Jul 2020 12:01:55 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id A5E8EC080E; Thu, 16 Jul 2020 11:55:58 +0200 (CEST) Date: Thu, 16 Jul 2020 11:55:58 +0200 From: Thomas Bogendoerfer To: Peng Fan Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mips/vdso: Fix resource leaks in genvdso.c Message-ID: <20200716095558.GF8455@alpha.franken.de> References: <1594729818-7859-1-git-send-email-fanpeng@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594729818-7859-1-git-send-email-fanpeng@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 08:30:18PM +0800, Peng Fan wrote: > Close "fd" before the return of map_vdso() and close "out_file" > in main(). > > Signed-off-by: Peng Fan > --- > > v2: > - add one missing fclose() > > --- > arch/mips/vdso/genvdso.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]