Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1134441ybh; Thu, 16 Jul 2020 04:14:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRYWsIA42UCQx0gctKrN3uCV8TWd+jSP0KmkX90FC9tCMnHjl1OuH2ENWneaknkMW7rq7q X-Received: by 2002:a17:906:48d3:: with SMTP id d19mr3159055ejt.180.1594898045520; Thu, 16 Jul 2020 04:14:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594898045; cv=none; d=google.com; s=arc-20160816; b=oQ3bIAMddzzmlRsL2Sxlei8Y1uLdIi/thxtYQep+AT9NS96JUB1mg3ExxYQ1f2VZRq +jMGwXK3NFKGzJhiyLt6nZ1WhLmKmmiLiFq4X1SrfxW265bNR3msF+6u0Dwi1jqC3ntn 3bq/LDiRCU/7iY53JKbbV8MjzQ0uauUWec5zV7LCX2xlK82HAl1km1d55jNm5+ckoqdW mykS/INO/LX1w74pt5otWnwSDMeWqmJ13TZI25LkeLC7o6DMh1VXPSYnDwMNUGJASzU5 IAYeo9TAg8cfTAKJ829SxJ3szoSazHdugQc8vwbnYXSsNZwtDd7luBDGGYFfD7mx60K1 mjhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qCmDCaxWedMHWRoRtTNbYwxLNouN++5yrZPd0I/yR78=; b=OC5d34jLpAxsyAzlM3NPG1lj2fFsKPEfOSIfmeiQhrmbMsHCUqWKWK8c0GH/dVVF+i AwahXWel/iZwqfBWeFrt4P+L/iOGG2Mz1Lzg2CUMRPepysxU1bhwerhYvCLikZARvajo t/i4q6CFAIN4nsQH5Fqp1hW6gmd3lL8qidvg6ElWk048G3BnAlrm0mpd/9XL6jbZ5If7 t6stqaMOiKnJEBKPqLkLP/Y4aOcG413MO/IVbtBLhHahadV6KUuJC24F93ygWNa7iiCC x0/+pAqR414v+2QShY7r3sM2zJ9VSrRzYbaFFlE6N92PUsfF4Si2f30FZvoM/s762mpr 8H6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si3042993edq.493.2020.07.16.04.13.42; Thu, 16 Jul 2020 04:14:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727831AbgGPLNd (ORCPT + 99 others); Thu, 16 Jul 2020 07:13:33 -0400 Received: from foss.arm.com ([217.140.110.172]:59056 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbgGPLNd (ORCPT ); Thu, 16 Jul 2020 07:13:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BF401FB; Thu, 16 Jul 2020 04:13:32 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED7383F68F; Thu, 16 Jul 2020 04:13:30 -0700 (PDT) Date: Thu, 16 Jul 2020 12:13:28 +0100 From: Qais Yousef To: Ingo Molnar , Peter Zijlstra Cc: Doug Anderson , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Patrick Bellasi , Chris Redpath , Lukasz Luba , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/3] sched/uclamp: Fix a deadlock when enabling uclamp static key Message-ID: <20200716111328.zkhncw2aurrs4mad@e107158-lin.cambridge.arm.com> References: <20200716110347.19553-1-qais.yousef@arm.com> <20200716110347.19553-4-qais.yousef@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200716110347.19553-4-qais.yousef@arm.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/16/20 12:03, Qais Yousef wrote: [...] > Fix by ensuring we enable the key outside of the critical section in > __sched_setscheduler() > > Fixes: 46609ce22703 ("sched/uclamp: Protect uclamp fast path code with static key") > Signed-off-by: Qais Yousef I am assuming this Fixes tag is still valid given the patch is only in tip/sched/core only. And that the hash value won't change after Linus merges it. Thanks -- Qais Yousef