Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1134579ybh; Thu, 16 Jul 2020 04:14:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcC+8hRHwBZz+/KSJt8TwXbREl3HMnJP2SNhJCP5Y3qk+CE82qXymEVPsofL+UkHrjzp/+ X-Received: by 2002:a50:fb93:: with SMTP id e19mr3874082edq.106.1594898059895; Thu, 16 Jul 2020 04:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594898059; cv=none; d=google.com; s=arc-20160816; b=jvol7NJawEjHwPOUlwYu6m3jyv6r3Bi8/YWKqbNosMWum8w0kFlMp6/A5oxEWO6Ga3 gi0vW4LnsLCEJMp+MymAAimd8NUHMEi9g+R+FKb9ue7tRtmEDTUhmc4hGWor29Zk1KqI gyDsfPJtk2xHntn4fC35iWBxABSgThJ0K0RMyb8f2eIZ4L0khUbaQmwzDTm+72g14bq3 C0JbxZJteMv3eVHikn9+03QNioOVBN5N7ycBXqWXAzwPlkDmvliJJPOyrFTxH9FPgWXW aT9skmrUq2cZyqRWqd7qqdtzr6ytNhjvl04Uu0kaICwuMSCDpzMlQb8tOICPk4pZ1ZsX umHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=MIfwPFkeASrdIJBRq4WmjAsAbelP9mj9BHCIlfLSEZs=; b=ekhDPz2mYl3EinDK4zxIU7dPME9ob9XGBsOO7rdfjNDafm0XmXjAgiY8+gKKVimcMI xSTK1d7vX9X+FvH5hoBwMjCBUAvfD3eksa1/6NipbbPicsdoqOUU+CmYpKs4f2+qik1k Hl+FeMU+/MrvlPWPIuNlPizFsD25sAapXiOH6qsSozXO4SeY+YuDsr1agmezFpIK9w4c oue9cDv1pPBz4TyXbwWZhOMd+JwkC9eXuJreBWVHrbHzVi+CwYyD+H1yJESb/pJ/70hN JaQxMEyq3D6fqPdEcda8g/8lq54ugmg9PVhj4y3FDYG1KQ9CgMwR/2zPzgB1FHAwDnm1 DGAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g21si3014247ejr.275.2020.07.16.04.13.56; Thu, 16 Jul 2020 04:14:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgGPLLi (ORCPT + 99 others); Thu, 16 Jul 2020 07:11:38 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2490 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726332AbgGPLLi (ORCPT ); Thu, 16 Jul 2020 07:11:38 -0400 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 18781E943ECF9A2B6D13; Thu, 16 Jul 2020 12:11:36 +0100 (IST) Received: from [127.0.0.1] (10.210.168.254) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 16 Jul 2020 12:11:35 +0100 Subject: Re: [PATCH] drivers/perf: Fix kernel panic when rmmod PMU modules during perf sampling To: Will Deacon CC: Robin Murphy , Qi Liu , , , , , , References: <1594891165-8228-1-git-send-email-liuqi115@huawei.com> <20200716094144.GC6771@willie-the-truck> <20200716103058.GE7036@willie-the-truck> <66a8eb37-b91a-d228-4ea4-8601e5518b31@huawei.com> <20200716104422.GF7036@willie-the-truck> From: John Garry Message-ID: Date: Thu, 16 Jul 2020 12:09:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200716104422.GF7036@willie-the-truck> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.168.254] X-ClientProxiedBy: lhreml714-chm.china.huawei.com (10.201.108.65) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/07/2020 11:44, Will Deacon wrote: >> Please also note what Qi Liu wrote about being able to unbind the driver and >> cause the same issue. I don't know if you can about that issue also. > I guess we have to throw in some '.suppress_bind_attrs = true,' lines as > well, then? Yeah, I think it would be a follow up using suppress_bind_attrs. TBH, I don't know why this is an opt out feature, than an opt in. Probably a good reason... I'll queue this as-is, but happy to take a follow-up if somebody > can test it. > Thanks, john