Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Jul 2020 13:31:12 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Paul A. Clarke" <pc@us.ibm.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        John Garry <john.garry@huawei.com>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 00/18] perf metric: Add support to reuse metric
Message-ID: <20200716113112.GC391962@krava>
References: <20200712132634.138901-1-jolsa@kernel.org>
 <20200715183327.GA21935@oc3272150783.ibm.com>
 <20200715214134.GW183694@krava>
 <20200716012504.GA27583@oc3272150783.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200716012504.GA27583@oc3272150783.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 15, 2020 at 08:25:04PM -0500, Paul A. Clarke wrote:

SNIP

> # perf --version
> perf version 4.18.0-214.el8.ppc64le
> # perf stat --metrics cpi_breakdown ./load >/dev/null             
> failed: way too many variables                                                               
>  Performance counter stats for './load':                                                     
>                                                                                              
>            818,130      pm_cmplu_stall_bru        #      0.0 bru_stall_cpi            (0.45%)
>      5,013,082,026      pm_run_inst_cmpl                                              (0.45%)
>                  0      pm_cmplu_stall_crypto     #      0.0 crypto_stall_cpi         (0.89%)
>      6,580,655,094      pm_run_inst_cmpl                                              (0.89%)
>         25,729,751      pm_cmplu_stall_dcache_miss #      0.0 dcache_miss_stall_cpi    (1.77%)
>      6,690,035,175      pm_run_inst_cmpl                                              (1.77%)
>                  0      pm_cmplu_stall_dflong     #      0.0 dflong_stall_cpi         (1.77%)
>      6,769,854,632      pm_run_inst_cmpl                                              (1.77%)
>                  0      pm_cmplu_stall_dfu        #      0.0 dfu_other_stall_cpi      (0.89%)
> [...and LOTS more...]
> ```
> 
> The second example in my previous post was from
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> branch perf/metric
> ```
> commit 7dd02cf0b9f04ca5339fa97f9a2280ebdd60b1db (grafted, HEAD -> perf/metric, origin/perf/metric)
> Author: Jiri Olsa <jolsa@kernel.org>
> Date:   Thu Jul 9 13:45:30 2020 +0200
> 
>     perf metric: Rename group_list to list
> ```
> 
> This build of `perf` fails:
> ```
> # ~/install/bin/perf --version
> perf version 5.8.rc4.g7dd02cf0b9f0
> # ~/install/bin/perf stat --metrics cpi_breakdown ./load >/dev/null
> 
>  Performance counter stats for './load':
> 
>      6,729,400,541      pm_run_inst_cmpl          #     0.00 bru_stall_cpi          
>             57,953      pm_cmplu_stall_bru                                          
> 
>        1.127319209 seconds time elapsed
> 
>        1.124906000 seconds user
>        0.000890000 seconds sys
> ```

ok, I can see that as well.. will fix in next version

thanks,
jirka