Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1165445ybh; Thu, 16 Jul 2020 05:08:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRaEr7wRojO1K6SXAySDJK30NcXM/wVK7yrL5gl02JzPMc88MvR2ewZKFXTBmF7im0PjML X-Received: by 2002:a05:6402:180a:: with SMTP id g10mr4332094edy.152.1594901330384; Thu, 16 Jul 2020 05:08:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594901330; cv=none; d=google.com; s=arc-20160816; b=L1ZDWPG7Uq1J0dMqKla64g2GHvJ3rLItMdLi64ehUKJAXdkUaeQUJtN1JfuKnacoVt LSxILd/Kkopc2WVa/Uef5Z0F0tSfp2i6KM2C7P+ZQhAVALOUiP3uBX9Gd3VKaBm4V4F1 6O0ACglVIRmzu6Smk7pGzgUij8n4rTFY+pWem0rI3AtrWpHmpOGLHmYNtwui5PKOdJw2 fgqeNBERnwOxoeZDnZ+1TpwRvaUIV02F7nGek4vn5Or9WlTVKR6uZK5Ae3+x56uTxmcc lFw7jGF8q4lK1UJyCGe80Bw5m0+DlJHUdQN9E+fYJTu5O+MsqFX7yg2FIQNHYlCFNSp9 rV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=XUk4uPpwTSITCEjYChNTScClwFq4uq08tlJDRMfMUmU=; b=SUVXWjKTAT5SqV9/QOehXV/hIjIhXG5SJVWRFmguEWcIEun9rrcaUNRPaDk068Ptf3 3kFIGXQIa2/GtSHP97QjCtoFnuJJJGfDINoj/DrhxXDKzmuDaO1S74juJwf9NpWRiM3+ NyqJOUi+RmWq1lZc+BYKwU8if4lFF8xs6c3pLUq2J5SCwkonQXqC68aFET5aRoajDE3H kdQfLVE86++GcxPi8NxGIlAPFCXR+kgIsYFhHp2DZNu+z0Mfb7d94kfeEBxD9bFtrdIg UsMR+7KEKCFDbE2waV0Hxg36lByd23kd4V0/UnXyeesZn1q9bSmDc5xMm0YU+X3TnpVA 5HWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si1075319eju.472.2020.07.16.05.08.27; Thu, 16 Jul 2020 05:08:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbgGPMHq (ORCPT + 99 others); Thu, 16 Jul 2020 08:07:46 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:45954 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727990AbgGPMHp (ORCPT ); Thu, 16 Jul 2020 08:07:45 -0400 Received: by mail-ot1-f66.google.com with SMTP id h1so3971271otq.12; Thu, 16 Jul 2020 05:07:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XUk4uPpwTSITCEjYChNTScClwFq4uq08tlJDRMfMUmU=; b=SL2I7pg1TZc9/YHL6wz1AWyvXdZGr5Z2twIjUEOBv3Zoptt1PEQwDUJsVrTk5sfZhH m47/EbxUlYY8eNiMfbccthTU20b4zpVDoCc+EetQbPW2SJt3Bagq+8Lb7/F0QKyABeRY C0I/1auhrVcUfpizva/2/tUjiss1cfyN/IZEFmRFEARqynNjRY9ncqu66XTv3p+a/RWY KMEN5wXcb/pbKhzm8WWZRp6SxtVhbbPNmYhOxDKNFm0GYu7Ye/OcesYrV7x6+VoHdJvZ NBP7LEXrAgrKCbxcyfmVZG4ZzoZyesO3rgXsact3tsokx5Z7NDU3tVXGV5Cgs3hbRSgR RIUQ== X-Gm-Message-State: AOAM531eZawOwvc3VBdmw4PBaN8vOEsgYzmMW1G6932IBZg75KBL16qo H0CTOmqWlUcs6TE73O18lPy+qzqZmP4X9Hgy+wQ= X-Received: by 2002:a9d:1c82:: with SMTP id l2mr3934854ota.167.1594901264631; Thu, 16 Jul 2020 05:07:44 -0700 (PDT) MIME-Version: 1.0 References: <3955470.QvD6XneCf3@kreacher> <000f01d65ae8$0c607990$25216cb0$@net> In-Reply-To: <000f01d65ae8$0c607990$25216cb0$@net> From: "Rafael J. Wysocki" Date: Thu, 16 Jul 2020 14:07:30 +0200 Message-ID: Subject: Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled To: Doug Smythies Cc: "Rafael J. Wysocki" , Linux Documentation , LKML , Peter Zijlstra , Srinivas Pandruvada , Giovanni Gherdovich , Francisco Jerez , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies wrote: > > On 2020.07.14 11:16 Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > ... > > Since the passive mode hasn't worked with HWP at all, and it is not going to > > the default for HWP systems anyway, I don't see any drawbacks related to making > > this change, so I would consider this as 5.9 material unless there are any > > serious objections. > > Good point. > Some of the tests I do involve labour intensive post processing of data. > I want to automate some of that work, and it will take time. > We might be into the 5.9-rc series before I have detailed feedback. > > However, so far: > > Inverse impulse response test [1]: > > High level test, i5-9600K, HWP-passive (this patch), ondemand: > 3101 tests. 0 failures. (GOOD) > > From [1], re-stated: > > . High level: i5-9600K: 2453 tests, 60 failures, 2.45% fail rate. (HWP-active - powersave) > > . Verify acpi-cpufreq/ondemand works fine: i5-9600K: 8975 tests. 0 failures. > > My version of that cool Alexander named pipe test [2] serialized workflow: > > HWP-passive (this patch), performance: PASS. > > From [2], re-stated, and also re-tested. > HWP-disabled passive - performance: FAIL. But I'm not quite sure how this is related to this patch? This test would still fail without the patch if the kernel was started with intel_pstate=passive in the kernel command line, wouldn't it. > Although, I believe the issue to be EPB management, [3]. Well, that's kind of unexpected. If this really is the case, then it looks like the effect of the EPB setting on the processor is different depending on whether or not HWP is enabled. > And yes, I did see the reply to [3] that came earlier, > And have now re-done the test, with the referenced patch added. > It still is FAIL. I reply to the [3] thread, eventually. > > [1] https://marc.info/?l=linux-pm&m=159354421400342&w=2 > [2] https://marc.info/?l=linux-pm&m=159155067328641&w=2 > [3] https://marc.info/?l=linux-pm&m=159438804230744&w=2 > > Kernel: > > b08284a541ad (HEAD -> k58rc5-doug) cpufreq: intel_pstate: Avoid enabling HWP if EPP is not supported > 063fd7ccabfe cpufreq: intel_pstate: Implement passive mode with HWP enabled > 730ccf5054e9 cpufreq: intel_pstate: Allow raw energy performance preference value > bee36df01c68 cpufreq: intel_pstate: Allow enable/disable energy efficiency > 199629d8200e cpufreq: intel_pstate: Fix active mode setting from command line > 11ba468877bb (tag: v5.8-rc5, origin/master, origin/HEAD, master) Linux 5.8-rc5 > > Rules for this work: > > . never use x86_energy_perf_policy. > . For HWP disabled: never change from active to passive or via versa, but rather do it via boot. > . after boot always check and reset the various power limit log bits that are set. > . never compile the kernel (well, until after any tests), which will set those bits again. > . never run prime95 high heat torture test, which will set those bits again. > . try to never do anything else that will set those bits again. > > To be clear, I do allow changing governors within the context of the above rules. Thanks for the feedback!