Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1183536ybh; Thu, 16 Jul 2020 05:39:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNIzPRXkkI3i50uvq0BJAhMlQQZ1NZ030mwXB4MEAxXxHyChj7viQ0vS3F/Fz+Oyr5IP3+ X-Received: by 2002:aa7:d04e:: with SMTP id n14mr4422381edo.161.1594903157145; Thu, 16 Jul 2020 05:39:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594903157; cv=none; d=google.com; s=arc-20160816; b=vrvQDRUH/+TiCPnLF67v897rqVfoTj4f7UPgZxWKFZUo9pYxdhtkpqSQ9+7ofWbVfD bgk8IQ7jzms3OyaD+IyYnvPHrwHknjQ61aOn7eB7SjYTZa5EVRxZwS15RiTutf7F4gKr NaYBrXXNkSU20vti1AkMo+dGeEsp0q+aYOHIfe8euNDTuEXnFdQxMs7sQp5iGPYXAD5m 5XPGrMOvi9kl5cRyzkAc/fjadrkba+gQU1jS6Y2cFrbBeGWqYIRPReQiext1r5s/MRM3 h+LpYdMrsHvPmoAZz9JWQvB3U/6R/OBws4kwLkXapfjTm+pkd0ZgD9aJ9TXjgHuI/UQP 33ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7PEBpAiVJ5Osru7T1DeeHK9CJ+Qz7JjAZMK73gmqZxQ=; b=UVgv8UkTlGMxm2LrEJza8CVzowvwX3c/WeE762PPel4tpf+WLfxOdShsGspO1bl3es 6iMmk+C8hScpLaNasNJaVFGJ3BXbrtKGv5tS2YLn+yYL2LtNKzVgwwkTnn1loKZnEenN CuwmDpI/DEtB9cbQyY6g9bhOcCjVqQhkYqNaXU27VorWPnHpFuHqgKc8pUnA2CfCTqBc WtPcXtUWs1S+27xCe5YGE0uO00x3K9wkAR/ZPu9KPLSLAGpZM/UIkB+Ae3FHIL2tG5dO guwCP0BiGq3tDudAFTumohkBT6US/ib2nVLjgYppzJ2/2/wCwSAu0Gw10GUhh0BeO2/q z/mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=twsJ8dEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si3043310edw.582.2020.07.16.05.38.53; Thu, 16 Jul 2020 05:39:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=twsJ8dEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728734AbgGPMiW (ORCPT + 99 others); Thu, 16 Jul 2020 08:38:22 -0400 Received: from vps.xff.cz ([195.181.215.36]:42166 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728237AbgGPMiO (ORCPT ); Thu, 16 Jul 2020 08:38:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1594903092; bh=qYblAUDIZRO1zNd6viLmd487utSDKXeq71xAotYuRG8=; h=From:To:Cc:Subject:Date:From; b=twsJ8dEYPvij0y+AoCQWI6o/pVtQvDIcj3LZsx/fOE5i4Z04daXViaOC8tLUCcaiM 5hsXrmtHlJ1vhTOfwZ4apIEonmeA5qbNcz/hHec+VEJ7h4Y7GPpat90ApH78CYsxuE uBk1Rl0P/nqZIO7Fs0HJx0O9g+jIYUE8crInr9Zs= From: Ondrej Jirman To: David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , Fabio Estevam , =?UTF-8?q?Guido=20G=C3=BCnther?= , Robert Chiras Cc: Ondrej Jirman , Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] Fix st7703 panel initialization failures Date: Thu, 16 Jul 2020 14:37:51 +0200 Message-Id: <20200716123753.3552425-1-megous@megous.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When extending the driver for xbd599 panel support I tried to do minimal changes and keep the existing initialization timing. It turned out that it's not good enough and the existing init sequence is too aggressive and doesn't follow the specification. On PinePhone panel is being powered down/up during suspend/resume and with current timings this frequently leads to corrupted display. This patch series fixes the problems. The issue was reported by Samuel Holland. Relevant screenshots from the datasheet: Power on timing: https://megous.com/dl/tmp/35b72e674ce0ca27.png Power off timing: https://megous.com/dl/tmp/dea195517106ff17.png More optimal reset on poweron: https://megous.com/dl/tmp/a9e5caf14e1b0dc6.png Less optimal reset on poweron: https://megous.com/dl/tmp/246761039283c4cf.png Datasheet: https://megous.com/dl/tmp/ST7703_DS_v01_20160128.pdf Please take a look. thank you and regards, Ondrej Jirman Ondrej Jirman (2): drm/panel: st7703: Make the sleep exit timing match the spec drm/panel: st7703: Fix the power up sequence of the panel drivers/gpu/drm/panel/panel-sitronix-st7703.c | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) -- 2.27.0