Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200618100852.13715-1-gengcixi@gmail.com> <2fae67c7637f4e978cb54c3b96090788@BJMBX01.spreadtrum.com>
In-Reply-To: <2fae67c7637f4e978cb54c3b96090788@BJMBX01.spreadtrum.com>
From:   Cixi Geng <gengcixi@gmail.com>
Date:   Thu, 16 Jul 2020 20:38:25 +0800
Message-ID: <CAF12kFseC4MMbEUk6CgW=Hpz_Hg-+fjwbLZKFdPu0K_EGtcPDw@mail.gmail.com>
Subject: Re: [PATCH V6] GCOV: Add config to check the preqequisites situation
To:     Greg KH <gregkh@linuxfoundation.org>, jslaby@suse.com,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-serial@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     Cixi Geng1 <cixi.geng1@unisoc.com>,
        Orson Zhai <orsonzhai@gmail.com>, zhang.lyra@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi All:
Does this patch need more modification?


> =E5=8F=91=E4=BB=B6=E4=BA=BA: gengcixi@gmail.com <gengcixi@gmail.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B46=E6=9C=8818=E6=97=A5 =
18:08
> =E6=94=B6=E4=BB=B6=E4=BA=BA: gregkh@linuxfoundation.org; jslaby@suse.com;=
 oberpar@linux.ibm.com; linux-serial@vger.kernel.org; linux-kernel@vger.ker=
nel.org
> =E6=8A=84=E9=80=81: orsonzhai@gmail.com; zhang.lyra@gmail.com; =E8=80=BF=
=E6=85=88=E7=86=99 (Cixi Geng/10039)
> =E4=B8=BB=E9=A2=98: [PATCH V6] GCOV: Add config to check the preqequisite=
s situation
>
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> used to check whether the prerequisites for enabling gcov profiling
> for specific files and directories are met.
>
> Only add SERIAL_GCOV for an example.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
>  drivers/tty/serial/Kconfig  |  7 +++++++
>  drivers/tty/serial/Makefile |  1 +
>  kernel/gcov/Kconfig         | 10 ++++++++++
>  3 files changed, 18 insertions(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index adf9e80e7dc9..6df002370f18 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1566,3 +1566,10 @@ endmenu
>
>  config SERIAL_MCTRL_GPIO
>         tristate
> +
> +config SERIAL_GCOV
> +       bool "Enable profile gcov for serial directory"
> +       depends on GCOV_PROFILE_PREREQS
> +       help
> +         The SERIAL_GCOV will add Gcov profiling flags when kernel compi=
les.
> +         Say 'Y' here if you want the gcov data for the serial directory=
,
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index d056ee6cca33..17272733db95 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,6 +3,7 @@
>  # Makefile for the kernel serial device drivers.
>  #
>
> +GCOV_PROFILE :=3D $(CONFIG_SERIAL_GCOV)
>  obj-$(CONFIG_SERIAL_CORE) +=3D serial_core.o
>
>  obj-$(CONFIG_SERIAL_EARLYCON) +=3D earlycon.o
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index 3941a9c48f83..f415c4aaf0ab 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
>         larger and run slower. Also be sure to exclude files from profili=
ng
>         which are not linked to the kernel image to prevent linker errors=
.
>
> +config GCOV_PROFILE_PREREQS
> +       bool "Profile Kernel for prereqs"
> +       default y if GCOV_KERNEL && !COMPILE_TEST
> +       help
> +         This options activates profiling for the specified kernel modul=
es.
> +
> +         When some modules need Gcov data, enable this config, then conf=
igure
> +         with gcov on the corresponding modules,The directories or files=
 of
> +         these modules will be added profiling flags after kernel compil=
e.
> +
>  choice
>         prompt "Specify GCOV format"
>         depends on GCOV_KERNEL
> --
> 2.17.1