Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1230126ybh; Thu, 16 Jul 2020 06:48:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOgmSrqbz7A8ogisGjXa6VJ/isdForq5Uz4IxdKvfERuevFMzJ8T3SvG+fKY2Fco5b8dOb X-Received: by 2002:a17:906:970a:: with SMTP id k10mr1501570ejx.236.1594907330478; Thu, 16 Jul 2020 06:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594907330; cv=none; d=google.com; s=arc-20160816; b=az+Kup6T2/B8n5jym9mZ6cjBwN7zstF5PWsp6BrwC2Yf0+gDY21woPsb/wepV3z21P T+7siLP3p7qte/b2qf0nSr12zcF3nt+fx/TINx3NMMMQZdSlExyAkFpjTeCFZlbU+zMy 3MtQJVWhVV9sS4JzgUkPEreUH4PUZt5xywFjGTQkS9wQ2sENVw84W+kRVPjBiSJRBqdZ jnk9co2idD/b4cxczApz7NJGvXAek8//AoQ5Swee9jsQ7TQwfGsXYnZAQvmdPuWgDvTR C08IF+HHIPe0uRSWXOWJdClgRAuv3gAFUqKlEFZRJ8jn+fObM0NqbPeUtaAAcF/1tHcA RSJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1Crn7XaTOFPhrYlDIsZatzqk+FDLvcbXlzkZjad2WAY=; b=R2IlKixI01EVrTqL0kwAnyJOmKVZV0ZZn6FKGaLAq7eLTs73WMukHxfThofcFmpxzb bSnYaH2+5McrtXTn0eM3Ut91tsLLiOqQzq7tBREF653g+cv8WDVjSWRsZ2n+yM+2odUk a0ORXjhTT1/lXedfAM1kV78GWzzEHwiy6mCFvefmfSjy1/Fro/3zSAy/zrEFMCLzlpts qWqRqFrEiDzO70P/lr39lviVge7WgVhIUtrpL6lDh1udX+Ow3YOno8whTKZ9nlUgQnXQ mpNi7WioQ8q84d8vh4Abs4kEprVSmbAPyYIXiMZj0Nim7EJ46WPx9RTnfTBUy6bOokTP XUgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZCu8CXIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z19si3165464eje.612.2020.07.16.06.48.27; Thu, 16 Jul 2020 06:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZCu8CXIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728597AbgGPNqI (ORCPT + 99 others); Thu, 16 Jul 2020 09:46:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbgGPNqH (ORCPT ); Thu, 16 Jul 2020 09:46:07 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DB4C061755 for ; Thu, 16 Jul 2020 06:46:07 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f18so11655433wml.3 for ; Thu, 16 Jul 2020 06:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1Crn7XaTOFPhrYlDIsZatzqk+FDLvcbXlzkZjad2WAY=; b=ZCu8CXInP03TrQAxb0+85FxBWLoCqTLjBYofXz9dz/MHBJ77oYeCkS8BZyB8PfsyfR h7cjuoHQ174FvNAJe35uUkTDTuLXEnw9B1Cflc08dT7LoiAJ9eS/MTClE919psUmJ1Yu p4hq+AQIbrL3c/EQPIxO7/uBvFi2BgRHqOB6Iaxhwlr7sxy4ZjOm3HmFduE5nVCaoc40 GLk8L5R5p6M8YK+HSwfbUvxTgwY7ielCaJZwmN2BYHiTS/+L6bfalaUV0qJPIu/KD7Kw S9tgrpiX2WcT4Xz3ZUF3ygTqzjgJ1Tn23fETuDN+PWti4AfK+fNPDv5fpTB+vXXq4CvH hiIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1Crn7XaTOFPhrYlDIsZatzqk+FDLvcbXlzkZjad2WAY=; b=ndDRHGHLDXosrgIZ7/iGhDU3wiFXjWBOLmjf26JGRMMzaLiAdr/HMXWWecLY5EiLRu ofPvjYKeNhjP7ZixF8/Ww1YaqMCOkPthAe9AzOFHPud17JvhbwWkvWzOymBQk8rJeMV9 Ent9f5+3S0v1u8CwFzi5+KRvijPN1Clq2gva1r6G1i2tJPeE8WvgO9g/3yRVahFi6Lv5 McUwOZYu2ZNrD+N3nZkDuda6Zz8h5+PSgScMCzINf6MjEq0QdP9HDQfEYLbFyiR3HymC +KBCCgnqjAGgvhGxjud1LN/cCZ/SO8JIAso2znwSoB06Ll/pxtsUxA3GKUPDrn44w+yz Tcbg== X-Gm-Message-State: AOAM532yi8hA/bC0Z8cdXyOHARCM18oNc/iNTVE9NXo06fS0kCzDByt5 5/6rj4fG0lmaJakeuyIcWJTDDQ== X-Received: by 2002:a7b:ca52:: with SMTP id m18mr4433464wml.92.1594907165870; Thu, 16 Jul 2020 06:46:05 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w13sm9162781wrr.67.2020.07.16.06.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 06:46:05 -0700 (PDT) Date: Thu, 16 Jul 2020 14:46:03 +0100 From: Lee Jones To: Qinglang Miao Cc: Greg Kroah-Hartman , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mfd: Convert to DEFINE_SHOW_ATTRIBUTE Message-ID: <20200716134603.GR3165313@dell> References: <20200716090236.13057-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200716090236.13057-1-miaoqinglang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020, Qinglang Miao wrote: > From: Yongqiang Liu > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yongqiang Liu > --- > drivers/mfd/ab3100-core.c | 15 ++------------- > drivers/mfd/ab3100-otp.c | 16 +++------------- > drivers/mfd/tps65010.c | 14 ++------------ Can you split this out into different patches please. > 3 files changed, 7 insertions(+), 38 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog