Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1234372ybh; Thu, 16 Jul 2020 06:55:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy30KTAgtNvmsArtC4zjJCHcwrJtxuzXU+5S1xMY2VvkgrmymzkWJiG1ngmLHGI5c2UTMXW X-Received: by 2002:a17:906:dce:: with SMTP id p14mr3747337eji.442.1594907756059; Thu, 16 Jul 2020 06:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594907756; cv=none; d=google.com; s=arc-20160816; b=VUlFeNhUsT5Iwfi8fazXKw3TkvAhNaHsWfIBIx6DNZAZy6iegELSdQIVuy2WSfaH80 yXmUSSGwsBcMa3pz9yAmvYP8xVVbPNpmnX3HXXxU6YSIZ73sFUbCem3Iecfue2Ln+Wr9 frn8ogb/HrOdaeOc4nnzxXmPW/SN1uvZWxJ+a9HpTl+PQky9o4AWv+N3XA2zuckCrABD 9Su2R6+HZ63Zdz5jUETOdfFBaU0vPP+uedXY88txJKgPuJWcsLbc8HTqg6SfSTPlAQHb xnRgWwYEwM9wArMgGAac0ykDscYAQZXKGfoNV+hejRebi3qL2fGL+mY61qFq4X0Z2+A6 Cdwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=65QcCnpAmDce81oUaFA3QmWLjs//tlPa4Tv3XmT8+FQ=; b=lp/Oc9d2cygClDksPSM+GkvTyvOZTGo/JBxao4TqX6BjBG7Xjfro/NUKunSpH6k/k7 oo2GCHfkrEg2cZ/9YaYzKXsHkv65yfV2THEYm1AcsRn6Jusu0SeMeGOwa/3+v6xOtcwU jK2INJmFFauj7yXJQfYiKpKka2T7vYmMwNmIFsTNO1E9GqJjMaa/fU3MpY48heOl1Zi5 L0jUxwMXFwKa+rAqe1464GXddTOvKtEBjm1HT/GW4psSouqu+nS+AjkztcTchpm1DFWp wmeiHCvk6o3nIC6AXCB8UB49k4DXc0bH8AwQPxCnxDaooGB9HRGIMOKzawzI1IFEan7c 5yug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si3289690edv.375.2020.07.16.06.55.32; Thu, 16 Jul 2020 06:55:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbgGPNyu (ORCPT + 99 others); Thu, 16 Jul 2020 09:54:50 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40536 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbgGPNyt (ORCPT ); Thu, 16 Jul 2020 09:54:49 -0400 Received: by mail-wm1-f65.google.com with SMTP id f139so11698214wmf.5 for ; Thu, 16 Jul 2020 06:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=65QcCnpAmDce81oUaFA3QmWLjs//tlPa4Tv3XmT8+FQ=; b=UTYNXgoD/PQPT8VgeMDlmKpwkhZyazb7d5OL9+XHUK4vcd1gyJ6rHmiaI5vRSin5Et Rj5cInFIrKwMYOXLAaoNpgFTA4rahrA8/LUdp22kiUAXYIqeIHMbp4ssbeFsXxOkRWqa WQTQo9/5M5v58eAznIWjlkRttxiJf1TszFbNAkpGznl23BqXnkfGaK0qlEsLoujPO/8l xApcJXuTtEwOLQbWLUjYOkj9P9pzUl9JchsAw5R3CuqL90b4yLDyJ412yfaJ0jcZtqaa 7uaR0UO4Z87nG3GvNbSkDY6xeP4QyLzE5YKM1XeQQV8jLWVevm307kk2UvRQ9QGlLD9J ikFQ== X-Gm-Message-State: AOAM533tM5ZEInt8AE/AzEBURS9j54E6cFqdeTNAdHwqoGtv6+3UCoVU D0eiMBMAJfq4wyIu8S76KNo= X-Received: by 2002:a05:600c:218f:: with SMTP id e15mr4169276wme.63.1594907687641; Thu, 16 Jul 2020 06:54:47 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id k20sm8457168wmi.27.2020.07.16.06.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 06:54:46 -0700 (PDT) Date: Thu, 16 Jul 2020 15:54:45 +0200 From: Michal Hocko To: Tetsuo Handa Cc: Greg Kroah-Hartman , Arve Hjonnevag , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , syzbot , acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, syzkaller-bugs@googlegroups.com, "open list:ANDROID DRIVERS" , linux-mm Subject: Re: [PATCH] binder: Don't use mmput() from shrinker function. Message-ID: <20200716135445.GN31089@dhcp22.suse.cz> References: <0000000000001fbbb605aa805c9b@google.com> <5ce3ee90-333e-638d-ac8c-cd6d7ab7aa3b@I-love.SAKURA.ne.jp> <20200716083506.GA20915@dhcp22.suse.cz> <36db7016-98d6-2c6b-110b-b2481fd480ac@i-love.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36db7016-98d6-2c6b-110b-b2481fd480ac@i-love.sakura.ne.jp> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16-07-20 22:41:14, Tetsuo Handa wrote: > On 2020/07/16 17:35, Michal Hocko wrote: [...] > > But in order for this to happen the shrinker would have to do the last > > put on the mm. But mm cannot go away from under uprobe_mmap so those two > > paths cannot race with each other. > > and mm1 != mm2 is possible, isn't it? OK, I have missed that information. You are right. Can you make this into the changelog please? -- Michal Hocko SUSE Labs