Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1267019ybh; Thu, 16 Jul 2020 07:38:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+t9BAeMlP9CbEhINXfBxrtVYWqnPp8GsTjYWuGKkytC8QMxJDHE/5jQm0KOsawlFivs6/ X-Received: by 2002:aa7:d4ca:: with SMTP id t10mr4776746edr.244.1594910280328; Thu, 16 Jul 2020 07:38:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594910280; cv=none; d=google.com; s=arc-20160816; b=Bifeva4ZiyjhdjaSGsHMIt/O0f5wTT2ySr1KKZ6FpF1wawGR427/WZvX4ZTB8l0PAw ffuDzi9NB/2B52oRbbthY45k/x7M/KkizI2InXthJRvq1EEgM+Dad0wran5t70IN2/DK WaCeBLbTmpvO2acQZI5Ol90512uV4iMKwZXKA1JnHFZPgSP1I+RFNRmmx8bu0XnbhBvX UNPHqk51CsetHOiEu1XVM34rtQu7KfUUnYMcYTHaTcjjEWqn1za3pDw9yb3D/RFrZIFO fOXX5ScaldT75Fv/R0ib5VF80HeQx7f9FVkW9Z68ALfqrzdLf2kiydtlXYZGQwHWMXWs zuSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nxkcrc5P7Qd7poz1LmdDvcMFnguH4wq4okmKRFsmWhw=; b=WeGr1FXvTCYZkUYGc0Ht/ldDVToG4YMCV8z5jibYYgMP6Mc+cgC4L0gqMYKcNfw1SM jx3E3XMAbod8eqSL7lUMyoiW+ATq/ZNKQjeYpVI9UYQHkC53vUQ5ej7NTnH0BRokCFac s9s1Mlb3TjtLxnp/Oi0NGpoft71kGxXK+DDEFDyAmqHVxt7Qq9uh5rOasHd4nWtvVNr3 0cjVjWelb/ZO868fyk2fwKKoqVB2sW4Lf1RnrwtOcWPKqBSVI883KleUgSottZVsE5FZ 6BoaqVvhKBDSwG8wXv7gg0N8cgMZjskPBrCkQcxaxz4LDfd8vBZmBKNkr+cpsvcmGzj5 ofVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d5zWQW7K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw22si3039781ejb.61.2020.07.16.07.37.36; Thu, 16 Jul 2020 07:38:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d5zWQW7K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbgGPOfB (ORCPT + 99 others); Thu, 16 Jul 2020 10:35:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:54486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgGPOfA (ORCPT ); Thu, 16 Jul 2020 10:35:00 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4C7F206F4; Thu, 16 Jul 2020 14:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594910100; bh=nxkcrc5P7Qd7poz1LmdDvcMFnguH4wq4okmKRFsmWhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d5zWQW7KcwQQwGsZLtlihkD9diBPlVE3DBlaRFuftlKxZJ9FVattsI4I5Lc5ENbS6 68oniVnmgwkk+HemvqlyT3+a+Hh1TY0Gnd7IxVfpyVYoSt8jOuG0WBzyiv3oJVZgbP AkJnG3L9x3uLfQ8tI5QQ0QFX+YzK4k1rEXAGhr6k= Date: Thu, 16 Jul 2020 15:34:50 +0100 From: Mark Brown To: Jerome Brunet Cc: Jing Xiangfeng , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback Message-ID: <20200716143450.GB5105@sirena.org.uk> References: <20200716132558.33932-1-jingxiangfeng@huawei.com> <1jzh7zegfw.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ADZbWkCsHQ7r3kzd" Content-Disposition: inline In-Reply-To: <1jzh7zegfw.fsf@starbuckisacylon.baylibre.com> X-Cookie: This login session: $13.99 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ADZbWkCsHQ7r3kzd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 16, 2020 at 03:29:39PM +0200, Jerome Brunet wrote: > On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng wrote: > > axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add > > the missed function call to fix it. > > > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > > Signed-off-by: Jing Xiangfeng > Thanks for fixing this. > Maybe it would be better to use the devm_ variant for the name instead ? Yes, that should be more robust. --ADZbWkCsHQ7r3kzd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8QZYkACgkQJNaLcl1U h9B59Qf/cQ/Ssu6kfNi9QbWnYWdZOWPmbzLXNPPSbdpuW2McJvjhrFAscgfM5b/m +ShTyHn5oEztIfyoIXlaCPsfmNJRBjLotRdmo8xlZ3FyzgxAE810aNDKwR4uaOnv lSByiQZOnNa3EhV5P1naQaRf/MLw35gsHixOxQBO3kLkkokx5GpL1F1quQC33N9l cNu6tviX29PziUhmYNdjr6nhhSsHB4qC7+l6YwQmR3DzEPeVTiW8b1lWsmWL1YQq fhLlNWrqQSBTs01/EUEmvCHnHZZTZUhJRpIozH8eGjvhvg9YeY1nRj0ggxClpGHh Dzc0HtU/KTKfLk8zhuQLhLrKBKGvzg== =gap3 -----END PGP SIGNATURE----- --ADZbWkCsHQ7r3kzd--