Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1268643ybh; Thu, 16 Jul 2020 07:40:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNxxQK/H0FO8+xe/pmnGakpvfc53jNXC3ObeAt2AMmy87RwhbTgvIiBFAR+NPvyRXCcx0R X-Received: by 2002:a17:906:7250:: with SMTP id n16mr4227648ejk.290.1594910432497; Thu, 16 Jul 2020 07:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594910432; cv=none; d=google.com; s=arc-20160816; b=A95QViYDhlrOd7wxGq9iyriom0K8892/5JN6qU9FQTjhYt9VpNxnoh85FdVTzki4dg KV/00JFPHICVseuMfLHclwz9yJKq6PiKWSE8nACXDjUWsu5/HgGIlEcJ2FmkchD4OhT8 bKIQoicSz5YVZrlCMcLZod+Un1/uReVXTT5mwnmzzaHrrGFopRIV70kLVObCTaIMJ/XM +aW1GoXoNwm+ahrwGZiKdCA94Ul6p+kbWfwbzQANWYqJ4jARxNp4IFTw5tH/40F42ap/ wwXTp9IggVam/lsRv62wSWGCl9DVKRYJog17QbJU/DU6Am0Zw2cnizpl8kb5IetlM2V1 /oMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DJnmpNBxvVl/ZMP/46gYqKpDqQRAsKI6Ow2ObKjI9IY=; b=FylLVVcB6cRuBgOlu4qvUXZXE/QL/wQ7Pz/r+aMPPHF9ayNsjT29x4eWbvAMFRMK7Z vwVvYl79/7Jfme3k51prZcrnKTqRKIlOnBFrRQQwiBBV+p3DITHJJEzyKflPeydMMgAZ lYMGo3zBy11yK68WpNM6RuUa0PnNtyq4DD0ZUVcEJ89yw513T2rWaoVCUwbVOYOa1LvC sbTpbfw/NXLNAKbt9BHmjZnIPFL6fNIXuh1AHFwk69M2V4pFr4Jn7lgM1g59U0k0Q63h ZyPVR8Ut6cwBl0pgY48E8Q7C6DRbtAjc8dnRfiK9hagUfjzo5I8r0dlWJ3LxEK1vLhfR AmEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b25si3158331ejv.236.2020.07.16.07.40.09; Thu, 16 Jul 2020 07:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728716AbgGPOjf (ORCPT + 99 others); Thu, 16 Jul 2020 10:39:35 -0400 Received: from verein.lst.de ([213.95.11.211]:34966 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgGPOjf (ORCPT ); Thu, 16 Jul 2020 10:39:35 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 90D1B68BEB; Thu, 16 Jul 2020 16:39:31 +0200 (CEST) Date: Thu, 16 Jul 2020 16:39:31 +0200 From: Christoph Hellwig To: "Rafael J. Wysocki" Cc: "David E. Box" , "Rafael J. Wysocki" , Len Brown , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Dan Williams , shyjumon.n@intel.com, ACPI Devel Maling List , Linux Kernel Mailing List , linux-nvme Subject: Re: [PATCH V5] drivers/nvme: Add support for ACPI StorageD3Enable property Message-ID: <20200716143931.GA23501@lst.de> References: <20200702225011.10932-1-david.e.box@linux.intel.com> <20200709184333.6241-1-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 01:12:26PM +0200, Rafael J. Wysocki wrote: > I would write this as > > if (fwnode_property_read_u8(acpi_fwnode_handle(adev), > "StorageD3Enable", &val)) > return false; > > return val == 1; > > to eliminate the redundant fwnode variable and untangle the last > checks somewhat. > > With that changed please feel free to add > > Reviewed-by: Rafael J. Wysocki Applied to nvme-5.9 with the above fixup.