Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Jul 2020 16:39:49 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     B K Karthik <bkkarthik@pesu.pes.edu>
Cc:     devel@driverdev.osuosl.org, Xiyu Yang <xiyuyang19@fudan.edu.cn>,
        linux-kernel@vger.kernel.org, Ian Abbott <abbotti@mev.co.uk>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Michel Lespinasse <walken@google.com>,
        Divyansh Kamboj <kambojdivyansh2000@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get
 rid of sparse warnings
Message-ID: <20200716143949.GA2230084@kroah.com>
References: <20200716141747.wewrnejrygosqhd5@pesu-pes-edu>
 <20200716142537.GA2176745@kroah.com>
 <CAAhDqq3EeWGOJHaW37iQN5UgmvTf3AP10fhrVdJ5GuYjBt8f3w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAhDqq3EeWGOJHaW37iQN5UgmvTf3AP10fhrVdJ5GuYjBt8f3w@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 16, 2020 at 10:28:06AM -0400, B K Karthik wrote:
> On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > > fixed sparse warnings by adding a cast in assignment from
> > > void [noderef] __user * to unsigned int __force *
> > > and a reverse cast in argument from
> > > unsigned int * to  unsigned int __user * .
> > >
> > > Signed-off-by: B K Karthik <karthik.bk2000@live.com>
> > > ---
> > >  drivers/staging/comedi/comedi_fops.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > What changed from previous versions?
> 
> As Ian Abbott said "Minor quibble: the reverse cast is actually from
> unsigned int * to"
> 
> Hence this is a change in the commit description.

How was anyone supposed to know this?  :)

> > That always goes below the --- line.
> 
> I did not understand this sir, can you please clarify?

Please read the documentation for how to properly version patches, it's
in the submitting patches document.  Do that and send a v4 for this.

thanks,

greg k-h