Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200716080836.2279-1-rayagonda.kokatanur@broadcom.com>
 <20200716080836.2279-3-rayagonda.kokatanur@broadcom.com> <CAHp75VeXBCqEhfna2mQaHv7bZKOrj+A6KkbCrMAfM=X9+boDjA@mail.gmail.com>
In-Reply-To: <CAHp75VeXBCqEhfna2mQaHv7bZKOrj+A6KkbCrMAfM=X9+boDjA@mail.gmail.com>
From:   Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Date:   Thu, 16 Jul 2020 22:49:14 +0530
Message-ID: <CAHO=5PEMou=a7Kqc=_ZJ8V9FQ=dHA0cJkkojdq91NBsO1Dp3TQ@mail.gmail.com>
Subject: Re: [PATCH V1 2/2] i2c: iproc: add slave pec support
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Lori Hikichi <lori.hikichi@broadcom.com>,
        Robert Richter <rrichter@marvell.com>,
        Nishka Dasgupta <nishkadg.linux@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy,

On Thu, Jul 16, 2020 at 3:44 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, Jul 16, 2020 at 11:14 AM Rayagonda Kokatanur
> <rayagonda.kokatanur@broadcom.com> wrote:
> >
> > Iproc supports PEC computation and checking in both Master
> > and Slave mode.
> >
> > This patch adds support for PEC in slave mode.
>
> ...
>
> > -#define S_RX_PEC_ERR_SHIFT           29
> > +#define S_RX_PEC_ERR_SHIFT           28
> > +#define S_RX_PEC_ERR_MASK            0x3
> > +#define S_RX_PEC_ERR                 0x1
>
> This needs to be explained in the commit message, in particular why
> this change makes no regression.

I didn't get what do you mean by "no regression", please elaborate.

>
> ...
>
> > +static int bcm_iproc_smbus_check_slave_pec(struct bcm_iproc_i2c_dev *iproc_i2c,
> > +                                          u32 val)
> > +{
> > +       u8 err_status;
>
> > +       int ret = 0;
>
> Completely redundant variable.
>
> > +       if (!iproc_i2c->en_s_pec)
> > +               return ret;
>
> return 0;
>
> > +       err_status = (u8)((val >> S_RX_PEC_ERR_SHIFT) & S_RX_PEC_ERR_MASK);
>
> Why casting?
>
> > +       if (err_status == S_RX_PEC_ERR) {
> > +               dev_err(iproc_i2c->device, "Slave PEC error\n");
>
> > +               ret = -EBADMSG;
>
> return ...
>
> > +       }
> > +
> > +       return ret;
>
> return 0;
>
> > +}
>
> ...
>
> > +                       if (rx_status == I2C_SLAVE_RX_END) {
> > +                               int ret;
> > +
> > +                               ret = bcm_iproc_smbus_check_slave_pec(iproc_i2c,
> > +                                                                     val);
>
> One line looks better.

Yes, but to have 80 char per line, I have to do this.
>
> > +                               if (!ret)
>
> Why not positive conditional?

Thank you for your review.
Will fix all above.

Best regards,
Rayagonda

>
> > +                                       i2c_slave_event(iproc_i2c->slave,
> > +                                                       I2C_SLAVE_STOP, &value);
> > +                               else
> > +                                       i2c_slave_event(iproc_i2c->slave,
> > +                                                       I2C_SLAVE_PEC_ERR,
> > +                                                       &value);
> > +                       }
>
> --
> With Best Regards,
> Andy Shevchenko