Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qRS0lJdWt2mPJE+xu/aC2t9UWP863/J/vusKTNpjXFF+QJsVxpzce/oTylJT6bqIlgd0+zWcZG
 fB5DrsqtHZwQ==
IronPort-SDR: byD278/IfocpfEvY4+Z42wXGoe586dGFMEkeqrIqtChu+Ejnhl5vibuLuTJNcfLsjqKDgPoIVX
 4W/hL94YZLRQ==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     Vaibhav Gupta <vaibhavgupta40@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "bjorn@helgaas.com" <bjorn@helgaas.com>,
        Vaibhav Gupta <vaibhav.varodek@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
        "linux-kernel-mentees@lists.linuxfoundation.org" 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Subject: RE: [Intel-wired-lan] [PATCH v1 5/5] e100: use generic power
 management
Thread-Topic: [Intel-wired-lan] [PATCH v1 5/5] e100: use generic power
 management
Thread-Index: AQHWTfgoFaQac82XOkWeVKZvQ3nVRakKnPRA
Date:   Thu, 16 Jul 2020 18:21:09 +0000
Message-ID: <DM6PR11MB2890D1376FC0E846C455E87DBC7F0@DM6PR11MB2890.namprd11.prod.outlook.com>
References: <20200629092943.227910-1-vaibhavgupta40@gmail.com>
 <20200629092943.227910-6-vaibhavgupta40@gmail.com>
In-Reply-To: <20200629092943.227910-6-vaibhavgupta40@gmail.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aed97eab-07cd-4bca-99bd-08d829b503a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 18:21:09.8459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AqNcvwEwmIHNyEqI/AIpAb+hS7n3ocaItAG5Gd6DZHodmpdbqVzJG8jEgR4fld7Bg80fbfU6LFO4ynapkfOLWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4513
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas@kernel.org>; Bjorn Helgaas
> <bhelgaas@google.com>; bjorn@helgaas.com; Vaibhav Gupta
> <vaibhav.varodek@gmail.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@intel.com>
> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
> skhan@linuxfoundation.org; linux-kernel-mentees@lists.linuxfoundation.org
> Subject: [Intel-wired-lan] [PATCH v1 5/5] e100: use generic power managem=
ent
>=20
> With legacy PM hooks, it was the responsibility of a driver to manage PCI
> states and also the device's power state. The generic approach is to let
> PCI core handle the work.
>=20
> e100_suspend() calls __e100_shutdown() to perform intermediate tasks.
> __e100_shutdown() calls pci_save_state() which is not recommended.
>=20
> e100_suspend() also calls __e100_power_off() which is calling PCI helper
> functions, pci_prepare_to_sleep(), pci_set_power_state(), along with
> pci_wake_from_d3(...,false). Hence, the functin call is removed and wol i=
s
> disabled as earlier using device_wakeup_disable().
>=20
> Compile-tested only.
>=20
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> ---
>  drivers/net/ethernet/intel/e100.c | 31 +++++++++++++------------------
>  1 file changed, 13 insertions(+), 18 deletions(-)

I do have several e100 based adapters still working and a few old systems w=
ith plain old PCI that still function, however all of these older systems h=
ave broken power management.  Regardless of if I use the kernel before or a=
fter this patch is applied, or even if the e100 driver is loaded or not I c=
an't get a reliable suspend / resume cycle to work on them.

I did run some basic regression with this patch against the remaining pro10=
0 cards I could scrounge up and aside from broken power management (again w=
ith or without patch) the system seems good, so (hesitantly) from a regress=
ion perspective I will go ahead and say...
Tested-by: Aaron Brown <aaron.f.brown@intel.com>