Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1486461ybh; Thu, 16 Jul 2020 13:35:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykFWWahTcw3Am9ANjYz3PEPN0UxceAX4NKPIgYxgNDNYVEJchHf1Nc9I1lGfAgz9w8WNrQ X-Received: by 2002:a05:6402:1655:: with SMTP id s21mr5912119edx.289.1594931730726; Thu, 16 Jul 2020 13:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594931730; cv=none; d=google.com; s=arc-20160816; b=BCxDt6LR24fffmyWmrqQoRLf50S5xLemFNYYfdr3v8OxldKwt1cnzHLKLU6znMoFsl 5vzyXiH91YwTJfayx4dKiDVe7kupiDWdEz6h92hqzz6yXTdZjgg8YQtFv5l+GE68wXJn Fq4EgoY0/c/XLYq6Ki7jSEBQzCl3JpYgPf7mawwBfr4F/8PyK9IVP2qZYn7JfxXbcdxi YZzZ/nHmKtcwZN3vlgujOyUulFZkHyxUD2l+HgAu4woJlPkWPRQOYcmWm7HaBUcqml13 eQ+qywMrIWmcseA8eH8Jt+HMGx0r37bruD3eFbePXxnXxlXQn1RxUg+Cf05jUhVHb8cr JN0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=rGq8mYIImgOnUh+CYOEW5YvmHzm73n0l++XfA9NdEUA=; b=VgGgYoSZ1kmCKiO7eXRbif/ukQF3/5kJ6lwxychobSQ0Ku20l8oHw8Sn1x9PdKgDCH K+IonZ6QOuB+7gSBu4Z4EHQzSAt47KbT+T+cFGVscl60a/iUciEzvH26+Hqd2GVpUoDi g3Utmi3R5vQ84lgHNUGch0Ucx4+ekhgSFR9YzHCGRBSFlUq1+cW582icaU3cfQKfb8jY wlhnRzGavBuqxwUOfqN494NcQTCMvsmDEYJWrc5lgRv0h7+x7tiM8/HJaYmQ0NESZkz1 F2VO9nzAPZPNsnMPO2FZTkC069E6si9DyLnKE4BIBTLRrUyKT6nwHQKbwsaxoG/7WBoy KpvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cH1b0WZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h23si3807500ejd.485.2020.07.16.13.35.07; Thu, 16 Jul 2020 13:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cH1b0WZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgGPUcH (ORCPT + 99 others); Thu, 16 Jul 2020 16:32:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:39408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgGPUcG (ORCPT ); Thu, 16 Jul 2020 16:32:06 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D23D207E8; Thu, 16 Jul 2020 20:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594931526; bh=Nqxulrodxo8eOevLZn2HwsAISOP60thSdFpkTzjHl1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cH1b0WZXXlqv/IqmIu/n/UBktooOBSfIG9m2vop4KbpespzV/W2T/ehiaxmj9JUg9 VxNDMKimDmjtZle3uDOyH349zcEXT9hXK0vlRLqQ6ZM7lffxf175iWlO4jslFBYEzJ 4PR5uaDaJLwyAUkGG3R+OUYtlQ67rXQPrFzrKj2I= Date: Thu, 16 Jul 2020 13:32:02 -0700 From: Jakub Kicinski To: Richard Cochran Cc: Sergey Organov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , John Stultz , Vladimir Oltean Subject: Re: [PATCH net] net: dp83640: fix SIOCSHWTSTAMP to update the struct with actual configuration Message-ID: <20200716133202.24b1b5d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200716185650.GA1074@hoboy> References: <20200715161000.14158-1-sorganov@gmail.com> <20200716185650.GA1074@hoboy> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 11:56:50 -0700 Richard Cochran wrote: > On Wed, Jul 15, 2020 at 07:10:00PM +0300, Sergey Organov wrote: > > From Documentation/networking/timestamping.txt: > > > > A driver which supports hardware time stamping shall update the > > struct with the actual, possibly more permissive configuration. > > > > Do update the struct passed when we upscale the requested time > > stamping mode. > > > > Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.") > > Signed-off-by: Sergey Organov > > Acked-by: Richard Cochran Applied, thank you!