Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1521519ybh; Thu, 16 Jul 2020 14:48:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykoX5Q9g4osbUPi5ksYUrQ0CUC/otEOkkAam/S32+i5JpVBZ+5aHUncQBOJPWHEkJ4Gph7 X-Received: by 2002:a50:8749:: with SMTP id 9mr6407394edv.80.1594936134579; Thu, 16 Jul 2020 14:48:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594936134; cv=none; d=google.com; s=arc-20160816; b=K9JMze9KkosiQAg8xP7FP/QGqfkcK39cQ/h/fApPhGCE6vJ60W/1VNQFMlZTinVmo3 bECMANCWl/2qDaZU84r7RM5RhzEgHgozvDwxs4AWCyRUF3ZYb4eeQFoMXOP6meuSWPJA 5yzsO1zuk7AqDa9WWMj6Gr8I63X6EoGb8cSbpbvHPpfumNyPYV2j+6Pn0jtngS3GRv3s 7nVBDZxLvml1/U77YSxxIoAUr6HK0HkKSVL+wUCcNiYpNR7vFU370IHSBlQJb1Dup9f4 yW4fRLOudTZ+r4d3zFopEa/nATB4jf2Uez09oBg1GU+d1E3YICB2hNJiN0qykP1nEOBS KloQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=V9Eeqh7PgKlWTvCFmgnhIAUg9ciidxCrzIsN/yLe5Bs=; b=H1pE/Z0EJEPDsgQiqyHKK0d+Q7K0dGXBwmoH6sQH+WPjGKjT2Mya2vw8Kt0Sune9z7 mMjblX6ozUR25jOgQrxzDvJDpx1HLHl5b8azQcGbs3UHw6l5RcotmAde58gmEoSXoXGG PkGq8K+ggDY5IRgoDyveX2IQmcBpqwKmnZRNPIsQw70DmlXvxpiiLWk5qFwzg3Zw8E3Y X8C/8emfrPfZC5EYcw6l9T5wfrke89WFosbCEjYrbXq4ZPZ1ANfJ/S54uoO8g7WHpyeF nmjWoIzsMuB4JIJ6QROZfK/qOKooTVQpL08TI9oHNlgzLGni6rrvuIC+ilxi3kRxzzhs Ny4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VJGGIGMW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si3927184edy.599.2020.07.16.14.48.31; Thu, 16 Jul 2020 14:48:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VJGGIGMW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbgGPVrU (ORCPT + 99 others); Thu, 16 Jul 2020 17:47:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:48042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbgGPVrT (ORCPT ); Thu, 16 Jul 2020 17:47:19 -0400 Received: from embeddedor (unknown [201.162.240.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E24C2158C; Thu, 16 Jul 2020 21:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594936038; bh=R1wmezTq7O+jQNI1Y7st2p9vf97tRS9M7P3I2u40jwY=; h=Date:From:To:Cc:Subject:From; b=VJGGIGMWKVzkoeGWZZGF51iN2nkrj/lpyBqVLHPoyxVTQRr4eLqh5PyFrJpUTKLDe xJDD1sH2UwyFzA3Qay6QxpW+Mk2QSQ8DT31BagkCJ66KCt/d2F2PrgEhdp3O4SOmIh Myr0Cd3dukWYUSGr1gNcWAPZfDJXoKhgTHX6KqZM= Date: Thu, 16 Jul 2020 16:52:42 -0500 From: "Gustavo A. R. Silva" To: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery Cc: linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH][next] i2c: aspeed: Use fallthrough pseudo-keyword Message-ID: <20200716215242.GA19193@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/i2c/busses/i2c-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index f51702d86a90..31268074c422 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -504,7 +504,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) goto error_and_stop; } irq_handled |= ASPEED_I2CD_INTR_TX_ACK; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_TX_FIRST: if (bus->buf_index < msg->len) { bus->master_state = ASPEED_I2C_MASTER_TX; @@ -520,7 +520,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) /* RX may not have completed yet (only address cycle) */ if (!(irq_status & ASPEED_I2CD_INTR_RX_DONE)) goto out_no_complete; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_RX: if (unlikely(!(irq_status & ASPEED_I2CD_INTR_RX_DONE))) { dev_err(bus->dev, "master failed to RX\n"); -- 2.27.0