Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1562933ybh; Thu, 16 Jul 2020 16:10:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgHd8hAObTus/Suo6cGQ7JLhQM5tbho+GhKP659BvAj1AS91dLgjk95DdBukyj89yN1oRF X-Received: by 2002:a05:6402:b23:: with SMTP id bo3mr6715387edb.331.1594941023890; Thu, 16 Jul 2020 16:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594941023; cv=none; d=google.com; s=arc-20160816; b=tUCEzna94rCo+8D1SHO53pR+lJDRHR13GysFxhbJeYkOQV7scRa/obT+O/sMFOfFKK eT5SVEctbSiatMLqPqAl6EflhWsaCppHwm/uSFAwiuTMOvh8/nzCIYd7YPnfP/WVLolA iVPdAiP/jHJ1J/iwmC+UwJ7/v3JNg40uTiasN1GPLjE3U3XluUxw0Z3OILmUU4urb55x xg22AnvaUht/NEynS/8st6olWFe2ntyDNk6Yn9tDdVukhhfbUQMv4GaAvX/2FSCHJFdV t1aAmlKse/byu4EICDDL1C87s/vE1SdIw2FfKFfhs+D8EKWkzSLPHKmCCkjmTZz8G2mq fJIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=IQ4O2kXu/48GGMSWcmenLqn3VSY97/qSJdItJz4Xank=; b=VUa5b4nXjWhxnh+LEGvJ10zbtVvZH/ENneCl1n1+W6Wy90lUKDQ5NRS7ThbU9nk7bO 6hPv0a8sml4q8fKicKKYpl0HVTdFxig0aBj8dp7uxUZXvWYYQDs9wz9cs6SO51/T2umC 3RevQQ5+XSRNHQfJOnYtzPAMti5VXwuQN+93ycwtq7tbhN5EDwID3bR2CoTBCytjPGHl EHImfSzMW4ywjEy3w4LY9Q/V2JNG/m4DdWofnnPmIBQmKkCYxgz0yrkRpN4AdGTBPlbN lf0fOVNSSjaHoTyewUiCSkHr3d0cST4jX8ifucs+kaqsSSYl7FD5TP4+jc3UiAmofCFt 6dIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=V4frLrDL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lv11si3705634ejb.106.2020.07.16.16.09.04; Thu, 16 Jul 2020 16:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=V4frLrDL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbgGPXIh (ORCPT + 99 others); Thu, 16 Jul 2020 19:08:37 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:14622 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgGPXIg (ORCPT ); Thu, 16 Jul 2020 19:08:36 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 16 Jul 2020 16:01:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 16 Jul 2020 16:03:34 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 16 Jul 2020 16:03:34 -0700 Received: from [10.2.163.115] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 16 Jul 2020 23:03:33 +0000 Subject: Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait To: Dmitry Osipenko , , , , , , , CC: , , , , , , References: <1594786855-26506-1-git-send-email-skomatineni@nvidia.com> <1594786855-26506-17-git-send-email-skomatineni@nvidia.com> <20d63eca-4b2b-584e-a391-a4fb64a16b40@nvidia.com> From: Sowjanya Komatineni Message-ID: <4690e682-8495-2327-87c7-c2f06a7a479d@nvidia.com> Date: Thu, 16 Jul 2020 16:06:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594940498; bh=IQ4O2kXu/48GGMSWcmenLqn3VSY97/qSJdItJz4Xank=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=V4frLrDLf7wzr0GcMAG5OoC/zyA5bktipRy0lGWuXWWDftChPohKciCAmm+JjbAoU pWjJmGcoJmpj6ldw7hsRba1+g472cWg97oF+ii67zUYi16RiqCRY9fRucdY+h0Wi8t fnSd/puBb2s02xeKlHXYNkCPWoCnMDg4VFL5Gs1++AfWgAlQGvxqmrMS+48dBbOEmF Q4E588yA44lTB776Z466paiOsjdg2Wh0qjSEtR3k0hsUnIMCGInCshsyOn+noXdF5f sJl3iEhJRGCPLut0Vyf/lh+t7UxCijNTSp3xOQkNlULfwoQcV3jZhiJiYAUtsMfbxH azPzNs2i2p4+g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/16/20 4:01 PM, Dmitry Osipenko wrote: > 17.07.2020 01:49, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> What keeps MIPI clock enabled after completion of the >>> tegra_mipi_calibrate() invocation? >> MIPI clock is disabled at end of tegra_mipi_calibrate and is re-enabled >> during tegra_mipi_wait. >> >> I think I should fix this to keep the clock enabled till calibration >> results are latched. >> >> All consumers of tegra_mipi_calibrate() will call tegra_mipi_wait(). >> >> So will remove clk_disable mipi clk at end of tegra_mipi_calibrate() and >> clk_enable mipi_clk at beginning of tegra_mipi_wait() > Isn't it possible to perform the calibration after enabling CSI and > before of starting the sensor streaming? Currently this is what I am doing. Triggering calibration start during=20 CSI receiver being ready and then sensor streaming will happen where=20 internal MIPI CAL detects for LP -> HS transition and applies results to=20 pads. So checking for calibration results after sensor stream is enabled