Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1574052ybh;
        Thu, 16 Jul 2020 16:33:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwZuyHAroxm6lPqaX05RBQ6k5jimGMwj8RYwQqskRrM/dz3geQkTXP2PMHmEfBOYTTz2cd/
X-Received: by 2002:a17:907:42d0:: with SMTP id nz24mr6337816ejb.135.1594942403013;
        Thu, 16 Jul 2020 16:33:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594942403; cv=none;
        d=google.com; s=arc-20160816;
        b=02ze58lfobpCda3RWTRv+PiX9n1adY/gRiWjKlgC7+jVgvesKJ1chRFmG7t7L47kak
         egthaX76NLWTJ912cvqhxMiEXWLFOMwTXxu92unXpnYVYXJ85jYbix64adx2lwvMptfe
         UbGOMrSDhuYeJU+VpLQSOlOeI6tjIVWjBVKkTUpKOJz+zypmGsjF/pbeLS2RcbueEyPO
         iJLpG/q/xpwQmHTo2KaEoUB2N31gYiaIm/rvqGSiIqrZoRmzimZhOaANJkmzh2Ui1yzP
         ZC8ij/fl2eFMawX8f6pgVtp+PGLoPWalQz7z9y96SXMJXVyL/DL2+EULIVJn0x8gyZ0Z
         g00w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=8rkN9PIKLB59SMi7kKXMUgG6uZDZbV3+Fs2u5hpdvn4=;
        b=c+NJVogPImgJfpmgRx6z7yoJ9VfWRp/xZYpsaovpD5p+kEsg+COHu31APuq9l+pHxy
         SLi4JKQ4mNBtetKYKUEhl2GAQ+ZHp9f8DA6u4c/VSKMhn2OvOUo0cOXc9bLKEnJ8CYfd
         djqgg0L/j5/6s2yMwRWtPj5SHpe1ZOhGgnXn1lqDlBYZkGd7AeWyoQ9caHPvRVdCyrbh
         q96FdYp9V9DXqBERSjT2MTYYDtjtNbLQaCY86yvEsG1L06L7Q1qJNEgXcLdImQfA78Sr
         GjU07+WP4RLJ8wpBTbLEo4tNiChpr/KY3o3xTbKM0MWPfG72VCWcoKFKgGnj/ZVy9R85
         M1Hg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HCXnERf9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id mc14si4114548ejb.282.2020.07.16.16.33.00;
        Thu, 16 Jul 2020 16:33:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HCXnERf9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727045AbgGPXcn (ORCPT <rfc822;zzmahb@gmail.com> + 99 others);
        Thu, 16 Jul 2020 19:32:43 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:8508 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726337AbgGPXcm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Jul 2020 19:32:42 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f10e35f0000>; Thu, 16 Jul 2020 16:31:43 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 16 Jul 2020 16:32:42 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 16 Jul 2020 16:32:42 -0700
Received: from [10.2.163.115] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 16 Jul
 2020 23:32:41 +0000
Subject: Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and
 supplies
To:     Luca Ceresoli <luca@lucaceresoli.net>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <leonl@leopardimaging.com>, <robh+dt@kernel.org>,
        <lgirdwood@gmail.com>, <broonie@kernel.org>
CC:     <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1594787096-26685-1-git-send-email-skomatineni@nvidia.com>
 <1594787096-26685-2-git-send-email-skomatineni@nvidia.com>
 <1df13fad-b5ce-3889-c240-3411e97598d2@lucaceresoli.net>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <ca9b3549-b39f-3110-671a-e856f4a7b2fa@nvidia.com>
Date:   Thu, 16 Jul 2020 16:35:34 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1df13fad-b5ce-3889-c240-3411e97598d2@lucaceresoli.net>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1594942303; bh=8rkN9PIKLB59SMi7kKXMUgG6uZDZbV3+Fs2u5hpdvn4=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=HCXnERf9E+rDQYx/GiVGq9zMh381sbqMKWS5iM+cFrNg7zeS1krCw2EhlvoirAQD6
         CVp/w+fJvTxiRNgRJ6biK8hm9orIdYPHNNsDbBOdUZJjmwgYTi85Uk+8FtsAx3R74V
         dSUPQ7S6p0CytUNGztEDXQg/UJb8dOlaOEqdEbjenhs4queB1x088eN3XttWRiSFHE
         pI7wGBhaCXMlN0Z1tV6GtIBko1NkVVtT0TUgS+xdHJXo9oBPsUL2gpqsocPJs6ruwa
         d9MoLoExreEsoK3Qew9A6VemEeYDPbQh1+3hHushCHMm0xcVZ8A7Bsg3GtIMN5m+qf
         k3J23Udywwkjw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/15/20 11:50 PM, Luca Ceresoli wrote:
> Hi Sowjanya,
>
> On 15/07/20 06:24, Sowjanya Komatineni wrote:
>> This patch adds IMX274 optional external clock input and voltage
>> supplies to device tree bindings.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> index 80f2e89..ee427f5 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> @@ -13,6 +13,11 @@ Required Properties:
>>   
>>   Optional Properties:
>>   - reset-gpios: Sensor reset GPIO
>> +- clocks: Reference to the xclk clock.
>> +- clock-names: Should be "xclk".
> Not sure where the "xclk" name comes from, the datasheet I have calls
> the pin "CKIN". Maybe using the same name as the datasheet is better?
>
> Other than that looks good.

Thanks Luca. Using xclk as its external clock to IMX274.

Datasheet uses it as INCK. Will update in v2 to use "INCK" as referred 
in its datasheet.