Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200716193141.4068476-1-krisman@collabora.com> <20200716193141.4068476-2-krisman@collabora.com>
In-Reply-To: <20200716193141.4068476-2-krisman@collabora.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Thu, 16 Jul 2020 17:20:02 -0700
Message-ID: <CALCETrWdCN5KsRUkrb8VoYGRBhy71P-MAHGWhuJ5y4Z3vByyvg@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] kernel: Implement selective syscall userspace redirection
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel@collabora.com,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Lutomirski <luto@kernel.org>,
        Paul Gofman <gofmanp@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 16, 2020 at 12:31 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>

This is quite nice.  I have a few comments, though:

You mentioned rt_sigreturn().  Should this automatically exempt the
kernel-provided signal restorer on architectures (e.g. x86_32) that
provide one?

The amount of syscall entry wiring that arches need to do is IMO
already a bit out of hand.  Should we instead rename TIF_SECCOMP to
TIF_SYSCALL_INTERCEPTION and have one generic callback that handles
seccomp and this new thing?

> +int do_syscall_user_dispatch(struct pt_regs *regs)
> +{
> +       struct syscall_user_dispatch *sd = &current->syscall_dispatch;
> +       unsigned long ip = instruction_pointer(regs);
> +       char state;
> +
> +       if (likely(ip >= sd->dispatcher_start && ip <= sd->dispatcher_end))
> +               return 0;
> +
> +       if (likely(sd->selector)) {
> +               if (unlikely(__get_user(state, sd->selector)))
> +                       do_exit(SIGSEGV);
> +
> +               if (likely(state == 0))
> +                       return 0;
> +
> +               if (state != 1)
> +                       do_exit(SIGSEGV);

This seems a bit extreme and hard to debug if it ever happens.