Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Jul 2020 18:27:19 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     "jingle.wu" <jingle.wu@emc.com.tw>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        phoenix <phoenix@emc.com.tw>, "josh.chen" <josh.chen@emc.com.tw>,
        "kai.heng.feng" <kai.heng.feng@canonical.com>
Subject: Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related functio n
 for page sizes 128, 512 bytes.
Message-ID: <20200717012719.GC1665100@dtor-ws>
References: <20200714105641.15151-1-jingle.wu@emc.com.tw>
 <20200716053912.GB1665100@dtor-ws>
 <1594880123.69588.jingle.wu@emc.com.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1594880123.69588.jingle.wu@emc.com.tw>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jingle,

On Thu, Jul 16, 2020 at 02:15:23PM +0800, jingle.wu wrote:
> HI Dmitry:
> 
> Just to confirm, the older devices (I assume that pattern 0 means older)
>  have version command that is numerically higher than the one for the
>  newer (pattern >= 1) devices?
> 
> >> Yes, Pattern 1, 2 are newer devices.
> 
> > @@ -324,7 +342,14 @@ static int elan_i2c_get_sm_version(struct i2c_client *client,
> >  			return error;
> >  		}
> >  		*version = val[0];
> > -		*ic_type = val[1];
> > +
> > +		error = elan_i2c_read_cmd(client, ETP_I2C_IAP_VERSION_CMD, val);
> > +		if (error) {
> > +			dev_err(&client->dev, "failed to get ic type: %d\n",
> > +				error);
> > +			return error;
> > +		}
> 
> Could you please tell me why this chunk is needed?
> >> Modify the old pattern IC firmware read the correct ic_type.
> 
> In the elan_i2c_core.c, move this code to elan_i2c_i2c.c. 
> static int elan_query_device_info(struct elan_tp_data *data)
> {
> 	.....
> 	if (data->pattern == 0x01)
> 		ic_type = data->ic_type;
> 	else
> 		ic_type = data->iap_version;
> 	.....
> 	return 0;
> }

I am concerned that unconditionally substituting iap_version for ic_type
for "pattern 0" devices will break check in
elan_check_ASUS_special_fw() as it operates on the ic_type returned by
ETP_I2C_OSM_VERSION_CMD and not iap_version.

Thanks.

-- 
Dmitry