Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbWEEVPF (ORCPT ); Fri, 5 May 2006 17:15:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751781AbWEEVPE (ORCPT ); Fri, 5 May 2006 17:15:04 -0400 Received: from nz-out-0102.google.com ([64.233.162.203]:61224 "EHLO nz-out-0102.google.com") by vger.kernel.org with ESMTP id S1751218AbWEEVPD convert rfc822-to-8bit (ORCPT ); Fri, 5 May 2006 17:15:03 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jzW/kOyP9j2zBP1gW4E1iHhzfLjc1ILK6b3MCSRwPQKadag0JVMeoeJZIFfVisjJZnCn6pAiaaGVkmM7hnVWMsYtyUACDSCjBnY8uoYxkZCi+FOZxukwdeYBSAzWn9eTGn4ItTRqvD8pY9gJ30zCD4X5sAVAgYkF/ecbd1CFppw= Message-ID: <9e4733910605051415o48fddbafpf0f8b096f971e482@mail.gmail.com> Date: Fri, 5 May 2006 17:15:02 -0400 From: "Jon Smirl" To: "Greg KH" Subject: Re: Add a "enable" sysfs attribute to the pci devices to allow userspace (Xorg) to enable devices without doing foul direct access Cc: "Ian Romanick" , "Dave Airlie" , "Arjan van de Ven" , linux-kernel@vger.kernel.org In-Reply-To: <20060505210614.GB7365@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <9e4733910605041340r65d47209h2da079d9cf8fceae@mail.gmail.com> <1146778197.27727.26.camel@localhost.localdomain> <9e4733910605041438q5bf3569bs129bf2e8851b7190@mail.gmail.com> <1146784923.4581.3.camel@localhost.localdomain> <445BA584.40309@us.ibm.com> <9e4733910605051314jb681476y4b2863918dfae1f8@mail.gmail.com> <20060505202603.GB6413@kroah.com> <9e4733910605051335h7a98670ie8102666bbc4d7cd@mail.gmail.com> <20060505210614.GB7365@kroah.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2044 Lines: 46 On 5/5/06, Greg KH wrote: > On Fri, May 05, 2006 at 04:35:17PM -0400, Jon Smirl wrote: > > On 5/5/06, Greg KH wrote: > > >On Fri, May 05, 2006 at 04:14:00PM -0400, Jon Smirl wrote: > > >> I would like to see other design alternatives considered on this > > >> issue. The 'enable' attribute has a clear problem in that you can't > > >> tell which user space program is trying to control the device. > > >> Multiple programs accessing the video hardware with poor coordination > > >> is already the source of many problems. > > > > > >Who cares who "enabled" the device. Remember, the majority of PCI > > >devices in the system are not video ones. Lots of other types of > > >devices want this ability to enable PCI devices from userspace. I've > > >been talking with some people about how to properly write PCI drivers in > > >userspace, and this attribute is a needed part of it. > > > > User space program enables the device. > > Next I load a device driver > > next I rmmod the device driver and it disables the device > > user space program trys to use the device > > No coordination and user space program faults > > Gun. Foot. Shoot. Why do we want to create problem like this when there is a simple solution to preventing them. All it takes is a couple of rules: 1) To use a device it must have a device driver. It may be as simple as a couple of lines of code. This driver will cause a device node to be created. 2) If a user app want to use the device it opens the device node. This builds a system where everybody knows what is going on. The driver knows that user space is using the device. Multiple user space users are blocked from conflicting because of the open. There is no way to shoot yourself in the foot. -- Jon Smirl jonsmirl@gmail.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/