Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1634189ybh; Thu, 16 Jul 2020 18:40:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUQCfrMIDxCC0CNjZsW8lWXDiy3DTKM99MdbxtezixM2cEz/yVNVLfZYXne24weEPzaXGl X-Received: by 2002:a17:906:26c7:: with SMTP id u7mr6266340ejc.13.1594950020003; Thu, 16 Jul 2020 18:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594950019; cv=none; d=google.com; s=arc-20160816; b=0xwsy6pCtWzI+AR4ZB692AR2nlkrcN2soQLiaHXKiSXiNp6dJD59vVhb3cEPr6Pxme IYvo0D43ehg9hAHB95xI308uX0m3Js8+6KVQ+fur/CH09AYkkUqya8l2Pcl80riohaQt +YxgilFlmQsZ6D0XtB2gr5qlgW12BzImJx+gooezrZTIodYuT0FZihAHOsGNDfmNgKe2 05JR8fSD00O4K0wCwmUT4WaW42oedQaBN8/YPFe+cr5/8MhB91PfXDki+vY7IkhrI31R 0cDZHWnrVlILk8ZULMYAHjy7Eu455AHRd8fWJBmj44LTHqM7AqTuIhorT4sQ+L+CjXt5 ZPcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=O/3UoLDfS6NdxHtkobsXNLowWAgsh1DWoA/IQzc+QmA=; b=yyaxZa8EppMWwlrHDLYNBPXvtHi7yYtNYuExce8VPv/+b9dQImrMX7CzgMQhIig/o3 GFQani31StQ7jLVZfpEXMqqgWqYHpFJZFrbqs6HhDqThF321EirRJc2OBx/p3M2gfAsL FsKb4F2+XzD9U6C2OUgkxa3G8iTkvHChtxMeSTTHXG7SAnI/a9qDpoJ3BNGCFirSH6D4 pLDvmi6mGL+qzcVwDZrvzAFGhJlYdpJp/IIReAtTb/trzD0EnkYUKiTttKVQuHWd4/zu Wtbhi9HJgdxGoFksE6Z8AfdLFPoT7pXrc9uIk3NmKwBKSjo3NmJkjEJjYEFO/xo136Hq HZPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si4536421edr.390.2020.07.16.18.39.57; Thu, 16 Jul 2020 18:40:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbgGQBhQ (ORCPT + 99 others); Thu, 16 Jul 2020 21:37:16 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:56106 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726130AbgGQBhQ (ORCPT ); Thu, 16 Jul 2020 21:37:16 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 70E8D18C6EFF26CF5C9E; Fri, 17 Jul 2020 09:37:14 +0800 (CST) Received: from [127.0.0.1] (10.174.179.91) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 09:37:12 +0800 Subject: Re: [PATCH -next] rsxx: Convert to DEFINE_SHOW_ATTRIBUTE To: Jens Axboe , Greg Kroah-Hartman , Joshua Morris , Philip Kelleher CC: , References: <20200716090432.13691-1-miaoqinglang@huawei.com> From: miaoqinglang Message-ID: Date: Fri, 17 Jul 2020 09:37:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.91] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/7/16 23:45, Jens Axboe 写道: > On 7/16/20 3:04 AM, Qinglang Miao wrote: >> From: Liu Shixin >> >> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > None of these apply against the 5.9 block tree, looks like some > read -> read_iter conversion has happened in another branch that > I'm not privy to. Hi Jens,     Sorry I didn't mention it in commit log, but this patch is based  on linux-next where commit <4d4901c6d7> has switched over direct  seq_read method calls to seq_read_iter, this is why there's conflict in  your apply.     Do you think I should send a new patch based on 5.8rc? Thanks.