Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gang He <ghe@suse.com>
To:     mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com
Cc:     Gang He <ghe@suse.com>, linux-kernel@vger.kernel.org,
        ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org
Subject: [PATCH] ocfs2: fix remounting needed after setfacl command
Date:   Fri, 17 Jul 2020 10:37:51 +0800
Message-Id: <20200717023751.9922-1-ghe@suse.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ghe-pc.suse.asia (60.251.47.115) by HK2PR06CA0009.apcprd06.prod.outlook.com (2603:1096:202:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 02:38:12 +0000
X-Mailer: git-send-email 2.12.3
X-Originating-IP: [60.251.47.115]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d30ae6d7-c0e8-4e32-b997-08d829fa74ef
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2297:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0401MB2297413C3597406D8A920F63CF7C0@HE1PR0401MB2297.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1247;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wgZ4czrAnKlZTS4dTI4YRmlucmgAJsNSii/AztrnKNm4QJq0hWrnVoK1l0eqtLjPq2ckPM1wZ+5bn8hafJJunr6ZjRTXX4tuVrdKJk1cglp4QVQ5YDMaT17fxtLoyFGCj31RNvC9oZlGzAj7z9VNweYTXxoCDuPkH5tMsC1aJFCZqR/9B+hmjv87otUft7vwiDc8aS1vFW4KM94Z88rDkrVLAxfY6FN/ac++jUJieKoXA6a71a5+XhsJpwEx/luYWZAYtGqYs/vIMzCHt+bdTYHh0K3UJudgg+I3N6BZOHq5pV389Ld8mH0C+qtIk6mb+nEwt1xO84UbKUTQLtq5c8E0NGABzWNWXco1y26A2vC2o2uvIT7+u+2HKULTnaw2
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0402MB3514.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(39860400002)(376002)(346002)(396003)(6486002)(1076003)(4326008)(26005)(66946007)(86362001)(66556008)(66476007)(6512007)(5660300002)(52116002)(8676002)(16526019)(316002)(186003)(4744005)(478600001)(2906002)(6506007)(8936002)(6666004)(36756003)(2616005)(956004)(55236004)(16060500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 8tfoRQ9WhgRoi5dE8zZsXptgJ/N+U4y45piIC8yvYh9asWK3ZPiNdVWzevuuZRniENeWFGsgAxfoZzKCUXUuaGEGLXSZYH2nT4GKfhiQZoZVzUnUaAIRh03/x73XXtypBrkU9BTexx0PqUhxTMaVnZEmGjVjeQ7YGkTnxVy0lap6MJ7kmMDe6RFbE8Fi5HvHJTi7JyRxkgVbsxofyG1uWZD0e9XNOgq4Udk33CRftxG1cxyzxy/cKmQ7j3NHPLeYb0T5OnuN055Z3g+CZacdGCdI2hlI75zHhx1AcX/Z7QCj5KZ7Bbcy6eTcjU7xmeFQB67Feg2HsNATavK8oK38zcjO4u34BwYwxHB4p3ytZ9jUK3TQ8nUGKAzj+/FgolVK5vsPIVyHQFCR8HtZoA7cdrJAzS1UzUUK15z3cxjRIgY7NgPId/bbtCF5Ao4dlC2rShMVOoRGW71fp6Mm05C5hTNb5rin4uBxApcIJ+7yKTI=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d30ae6d7-c0e8-4e32-b997-08d829fa74ef
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3514.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 02:38:15.9272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xEC5grSgCIlCxeCX5jtiLJHCcjvbESlObMF1fu6c6mRVZigFV2UogDqd4WbipPqe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2297
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When use setfacl command to change a file's acl, the user cannot
get the latest acl information from the file via getfacl command,
until remounting the file system.
e.g.
setfacl -m u:ivan:rw /ocfs2/ivan
getfacl /ocfs2/ivan
getfacl: Removing leading '/' from absolute path names
file: ocfs2/ivan
owner: root
group: root
user::rw-
group::r--
mask::r--
other::r--

The latest acl record("u:ivan:rw") cannot be returned via getfacl
command until remounting.

Signed-off-by: Gang He <ghe@suse.com>
---
 fs/ocfs2/acl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index bb981ec76456..7b07f5df3a29 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -256,6 +256,8 @@ static int ocfs2_set_acl(handle_t *handle,
 		ret = ocfs2_xattr_set(inode, name_index, "", value, size, 0);
 
 	kfree(value);
+	if (!ret)
+		set_cached_acl(inode, type, acl);
 
 	return ret;
 }
-- 
2.12.3