Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1592483471-14806-1-git-send-email-hanks.chen@mediatek.com>
 <f47e8a1e70c982ecf6245db573630f51@kernel.org> <1592490123.10773.16.camel@mtkswgap22>
 <1592894173.10773.42.camel@mtkswgap22> <3dc953265ed4cd4300bd9600bf7e33d6@kernel.org>
In-Reply-To: <3dc953265ed4cd4300bd9600bf7e33d6@kernel.org>
From:   Saravana Kannan <saravanak@google.com>
Date:   Thu, 16 Jul 2020 19:55:41 -0700
Message-ID: <CAGETcx-daJxJ=Werw9fkmWHz=iUq1S-S63fz8KaKB4S-D+0oZA@mail.gmail.com>
Subject: Re: [PATCH 1/1] irqchip: Add config MTK_SYSIRQ and MTK_CIRQ
To:     Marc Zyngier <maz@kernel.org>
Cc:     Hanks Chen <hanks.chen@mediatek.com>,
        CC Hwang <cc.hwang@mediatek.com>,
        Jason Cooper <jason@lakedaemon.net>, wsd_upstream@mediatek.com,
        Loda Chou <loda.chou@mediatek.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 23, 2020 at 1:37 AM Marc Zyngier <maz@kernel.org> wrote:
>
> + Saravana
>
> On 2020-06-23 07:36, Hanks Chen wrote:
>
> [...]
>
> > Hi Marc,
> >
> > I want to break the dependency between ARCH_MEDIATEK and CIRQ/SYSIRQ,
> > because we need to follow the GKI.
>
> This isn't what GKI mandates. GKI requires that the SoC code is compiled
> as modules, not that it is dissociated from its platform (which would
> be completely pointless).
>
> > Could I add the MTK_CIRQ and MTK_SYSIRQ into defconfig?
> > (arch/arm64/config/defconfig)
>
> I don't deal with defconfig at all. That's a patch for the arm-soc
> people.
>
> >
> > It would ensures all platform are executable.
> >
> > e.g.
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> >
> >  CONFIG_QCOM_PDC=y
> > +CONFIG_MTK_SYSIRQ=m
> > +CONFIG_MTK_CIRQ=y
> >  CONFIG_RESET_QCOM_AOSS=y
> >
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -572,4 +572,18 @@ config LOONGSON_PCH_MSI
> >         help
> >           Support for the Loongson PCH MSI Controller.
> >
> > +config MTK_SYSIRQ
> > +       tristate "Mediatek interrupt polarity controller"
> > +       depends on ARCH_MEDIATEK || COMPILE_TEST
> > +       help
> > +         Interrupt polarity controller driver to swap polarity for
> > +         interrupts for Mediatek mobile chips.
> > +
> > +config MTK_CIRQ
> > +       bool "Mediatek low-power interrupt controller"
> > +       depends on ARCH_MEDIATEK || COMPILE_TEST
> > +       help
> > +         Low-power interrupt controller driver to monitor IRQS
> > +         in the sleep mode for Mediatek mobile chips.
> > +
> >
> >
> > P.S I'll make the irq-mtk-sysirq driver as a loadable kernel module for
> > GKI
>
> You might as well turn both drivers into modules. Saravana was working
> on a set of patches to ease this transition.

Sent out v2 of that patch now.
https://lore.kernel.org/lkml/20200717024447.3128361-1-saravanak@google.com/T/#u

-Saravana