Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbWEEWPE (ORCPT ); Fri, 5 May 2006 18:15:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751795AbWEEWPD (ORCPT ); Fri, 5 May 2006 18:15:03 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:54541 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1751794AbWEEWPB (ORCPT ); Fri, 5 May 2006 18:15:01 -0400 Date: Fri, 5 May 2006 23:14:54 +0100 From: Russell King To: "Paolo 'Blaisorblade' Giarrusso" Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] device core: remove redundant call to device_initialize. Message-ID: <20060505221454.GH10974@flint.arm.linux.org.uk> Mail-Followup-To: Paolo 'Blaisorblade' Giarrusso , Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20060505153907.12756.23295.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060505153907.12756.23295.stgit@zion.home.lan> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 17 On Fri, May 05, 2006 at 05:39:08PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso > > platform_device_add calls device_register which calls then again > device_initialize, redundantly. platform_device_add should be using device_add not device_register. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/