Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1691802ybh; Thu, 16 Jul 2020 20:59:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwInc1EZamKEDxUoTjG6OEY4XwzoJe8ABVFy2W/imB+UopSiAYJv9TUE4DocQAyTz20Ka4P X-Received: by 2002:aa7:c2c5:: with SMTP id m5mr7531067edp.214.1594958358385; Thu, 16 Jul 2020 20:59:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594958358; cv=none; d=google.com; s=arc-20160816; b=svD+6+mPiKoBWTGhAV19BTM3XsFerVlIypFTqTonFr2/lxvF04YNQkbgHNyrXWGuE6 FFOA8eTi8X1+ZdqJ4HCAKqlwzvRTpwtDsWF3IbbMjWuc7YDdy4m6PjW7iB/GD6j4JYJG w0i73rzNC8y0i1t8W0Y1yyfskNJ+owvB2XZNcQiIpbjVo2k8MnDy95wQh7auDgQ8CvIk ZYAb2npCEugjQ/mCn9t6FMh5KTwvC9xk3R2xoczW/TVt9GspwyKYEpP6KhojvUQbu1Dj RnDGMSKhVJVk1K4da1nx+CCEzr8f0KbpKbxg4rnFdWi6Hh1iY9GRplk7i9Kz6Xqk2oRj zPRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zkwfq5Uv+GY1uwPYszvR2jSGTXRIJ42mdhpNQh9+c3E=; b=PrZM6DU51Ar99Lr/kS5TMseWhxMpmQ014Rm9W81n09ZNEluYhVaeHCrnouz1qxpEGl wsrlM6y47TCGOatltVUE2QULLDscdeOCF9JLWu5A56dmuSKSd6AWeOz6M01tu1kfGwyg vxaXVeDxWjv00oDbJAnz315YWWEPaymVH0mzQkLRMIFlLvDo5MFz3DcVZ4t+/CFNy8wX 47egqNazrPVy4V49MbD0PgUU+IVCSaMCYz0Ly9rePXzr2BJvBaTkGNhhjSgA2ZAdxpCM aAolD69/2lenctp9LzZqWs6yXYzzs+q52kbqtEkzayF3zfH9n3xIVEvRrdZu5dq2+uFI gJGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lhuvquXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk4si4198753edb.358.2020.07.16.20.58.55; Thu, 16 Jul 2020 20:59:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lhuvquXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgGQD60 (ORCPT + 99 others); Thu, 16 Jul 2020 23:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbgGQD6Z (ORCPT ); Thu, 16 Jul 2020 23:58:25 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB62C061755; Thu, 16 Jul 2020 20:58:25 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id t15so5744398pjq.5; Thu, 16 Jul 2020 20:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zkwfq5Uv+GY1uwPYszvR2jSGTXRIJ42mdhpNQh9+c3E=; b=lhuvquXTh98LzGrLH3A6gsJcb/6gr9Yecke49um+BtmAznQ7j2KoJdKAYYMrCJ4jtu q+E31pDYVZ5SY8mIlr+06VbIncUv3I5fluiXXnFVCmFxFmEqw9T1XiF3ziRuG9IYvoBp 8Qs+P7bdPnmXdydbtcQP56KBvIFF+8JLIAfKiKZPv6YNlBs7isW9PGf/aMbKIfqT26MF s2CG9YSISdUW4sMafArMv0X0stcOZH2rGTBYZ6kZLw9QuXRjIzOZ1/hZ2PXx9SufkOQp MeVz4WDm+3DdKP2htXG89eLCmTIgEYNNFXawb9i+mpcxQevDy70rIBJZw9gu4r2eRNxD tn6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zkwfq5Uv+GY1uwPYszvR2jSGTXRIJ42mdhpNQh9+c3E=; b=SJD5Rqn/bqsPGVIN0qJaHccPhXdcNUgxHBw9piMbDsttFK/P0uVp9lvydBZX0bFuff ySavMBdYsJpgCQEWhOsyco3F6b2LXqZ/7LYLT5qVZzryjfoykUYZY8utmVhz9AzzsIG6 0N/2pXqkIp0T3f73O3KKyGBg2K9wr+yioix921uFAokjvYdCHCKRpVFauQ7kvY/ACGoH HjXcQO7W0RcC4hn7uRhjdjo4m/Nz0lhEBnTHY07Gbue7cPKp9IW0E+4049lC7MqjkdVR 85ZdlQb3aqHay5ZZPQoHJIXlo50G1CxMCW6YXeZ5pvRaWNpIwxUaraD+zc8k19ZfBI1q Sn/A== X-Gm-Message-State: AOAM530ZnoIBKyUr4UAQQ1KzntJBBdDpziFTdz791xmZhOvpV3Fk24SG 6K+pSG++qAvzSs7Rd/DeIn0= X-Received: by 2002:a17:90a:db82:: with SMTP id h2mr8156594pjv.162.1594958305431; Thu, 16 Jul 2020 20:58:25 -0700 (PDT) Received: from varodek.iballbatonwifi.com ([103.105.153.67]) by smtp.gmail.com with ESMTPSA id v11sm6227907pgs.22.2020.07.16.20.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 20:58:25 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mauro Carvalho Chehab Cc: Vaibhav Gupta , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: [PATCH v2 2/6] cx23885: use generic power management Date: Fri, 17 Jul 2020 09:26:04 +0530 Message-Id: <20200717035608.97254-3-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200717035608.97254-1-vaibhavgupta40@gmail.com> References: <20200717035608.97254-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/cx23885/cx23885-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/media/pci/cx23885/cx23885-core.c index 7e0b0b7cc2a3..4b0c53f61fb7 100644 --- a/drivers/media/pci/cx23885/cx23885-core.c +++ b/drivers/media/pci/cx23885/cx23885-core.c @@ -2235,9 +2235,6 @@ static struct pci_driver cx23885_pci_driver = { .id_table = cx23885_pci_tbl, .probe = cx23885_initdev, .remove = cx23885_finidev, - /* TODO */ - .suspend = NULL, - .resume = NULL, }; static int __init cx23885_init(void) -- 2.27.0