Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1691903ybh; Thu, 16 Jul 2020 20:59:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww6QL33paaNJEmiK+CxYvYMjsw/TMVKHag9GytXsySdYbaOa6Q53eD/8VUgTFw6MatPLK0 X-Received: by 2002:a17:906:7005:: with SMTP id n5mr6427017ejj.130.1594958369434; Thu, 16 Jul 2020 20:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594958369; cv=none; d=google.com; s=arc-20160816; b=IBnc/Z73J/zggHHBvkWRvylCwJqfKQmuUuchqd2zmlmfCZ0PNy6bM58LqEQh7kcxXA 4kMRiQkLJlQNsVJX08H8ZDADE29hb5Glae2fItPByIyK4oI/ojxGHLCnuy/DImgyPGJO nCTBLKBAEZu5l6MWqypAIfKl4kRJ9XdNnR7RgSVR8gje1Rles82tizs7FEafihz9exVL N8WGqEXvnjHUtNKAnmSuo1J+ql5ajQZvXPZmDbox0US9vTQcNuXkw10utS3iOOSB2aNV VtjHZPifmANlDLsWfrTWv6vGF7Nr07VBWNm/QH4XZU2F02P3tmmK5YRHIbygfHF+rmXa W7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=iSZbXJa6c3yw9xktjm1eC0Mc3tJ4AFiaAAnkovwcsjMt87XePTgyqHNOFSpDcdcdlC Jl29XB33H/a2/vLIncP8uK/Ph9NaHAqehSST1Wjf2ugBTdV+5tyNV1ZRhysPLYXI9paB 7V59xS5y9/fTZn1J9E9Il1jYGKQfQD677gNYEIY5gznXZaoW4iBFbr+8P8cu8rzel0a0 l6pBnZcJLH2FGwVkWOhZugGTVklVsgg09sLApMpH9AgIbOK8zNT3cXCHdlz8T7Vyw6xh 9GyaC4By3ZZTIUp0FWtuIGHYMzhEAx3q9QVqawt6hEghnpjctLB0LhuACWWpMeT+oiR4 UJ5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKpE8LOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r5si4424206edo.130.2020.07.16.20.59.06; Thu, 16 Jul 2020 20:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKpE8LOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbgGQD6m (ORCPT + 99 others); Thu, 16 Jul 2020 23:58:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbgGQD6l (ORCPT ); Thu, 16 Jul 2020 23:58:41 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E966C061755; Thu, 16 Jul 2020 20:58:41 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id z5so6033307pgb.6; Thu, 16 Jul 2020 20:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=bKpE8LOjMvFIC6gWt1Rw1tJ7UdBTguCQsj3+hovT5dVVSMINoc2pucCNbUUnbTkIup fOYndAIcKasKzo2sCIFJpj5z2pHQ3zW/YBhK2UyErJpjDAWzD5xMZBE0IuazYc6yoagl llPHEsuW3TyFWfs878gNgNyoBaLbYyTYXtg9VfTLnwMuIJQKImcSTwpm19AlK763gDiU xHvkPpTMGSwUBvAL/fzqaiTXm4fXHYuPOCvys5xTQYqSLXoCpg9jjYXRiDCHbEdY0g7c 7qV8vNk6VLM0S/6N8kh1yI/xJ7FhojVNW1Fb40c0h9pktvLb9x4XRyfG4StDAy8nVS/f iUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=qXjQWF/O8nlkGPS2m9X5ceX2qJcpJ+xPGk+CzwwviKKz6YT97i9k9g7P90ja/mg+Gb gN1DkUQeraj3cBr/vMVG7ml88hBvNE93xUtW1pUNNN0wGrUZWpYZzfiZ6Pu9LcOCnlGS hAgwnOi94JWThA8mddppuAKUBA4JBAVEml6sp/G6TGbTxHlf9G8yBzNct1JwX2fHuwPb E5oU0HACzF0oWsLZE/L8PhXKpGc5XdV4/6WECMrN4yuCrCI8FJp9Wjxxo5y7e6i88J6k 2GBPxbAuS9HavDGbF/eh5KLiT+/2wyqVQOYVZ7QKHG/V/Pc1DmyZOc3OYjk9HI77QXer OoXw== X-Gm-Message-State: AOAM533YfpsvbnRrMlXKCBqH7YcA6E5MXGvdAllGYZUQ+PZ1OGkIdXgh G+9Zo+awuev8iguY/vxPFVE= X-Received: by 2002:a65:4502:: with SMTP id n2mr7042061pgq.132.1594958320850; Thu, 16 Jul 2020 20:58:40 -0700 (PDT) Received: from varodek.iballbatonwifi.com ([103.105.153.67]) by smtp.gmail.com with ESMTPSA id v11sm6227907pgs.22.2020.07.16.20.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 20:58:40 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mauro Carvalho Chehab Cc: Vaibhav Gupta , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: [PATCH v2 3/6] cx25821: use generic power management Date: Fri, 17 Jul 2020 09:26:05 +0530 Message-Id: <20200717035608.97254-4-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200717035608.97254-1-vaibhavgupta40@gmail.com> References: <20200717035608.97254-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/cx25821/cx25821-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/media/pci/cx25821/cx25821-core.c index 41be22ce66f3..55018d9e439f 100644 --- a/drivers/media/pci/cx25821/cx25821-core.c +++ b/drivers/media/pci/cx25821/cx25821-core.c @@ -1374,9 +1374,6 @@ static struct pci_driver cx25821_pci_driver = { .id_table = cx25821_pci_tbl, .probe = cx25821_initdev, .remove = cx25821_finidev, - /* TODO */ - .suspend = NULL, - .resume = NULL, }; static int __init cx25821_init(void) -- 2.27.0