Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1752969ybh; Thu, 16 Jul 2020 23:26:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9b2pTJ+JbjCNkucz+YquHKtSP+j7OcAgTpqzBbHW0vUfskW1xLotz+19vB/C5lwLVAb2c X-Received: by 2002:a17:906:7017:: with SMTP id n23mr6945994ejj.262.1594967161923; Thu, 16 Jul 2020 23:26:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594967161; cv=none; d=google.com; s=arc-20160816; b=NPR+wvgRJyoTEI7lex2b8yVeokA5HAxunCn39kg9KHJdmfTsWsoKi0IOyHt/8xaR5a +bShdwuxQ8c4ZSUeMqU0c9je/qo1HH0S60SVe/6pAyj5P/aLPT+sjk0WBUm9Ji2i38lv OgtluL9cXsiCq8RPBCne+EqRK0Aaomtv2FGcf6oNn1/rLnyTYM4Aam1GKALcSOsVQbyM uRN0bEoUc/70Vm1hbsQto6RKjxeG4Y6dZRArWfjCyCRZDENdnY/G+nOTpeLv6bVbUm0A AgT7CdaFdWxgK14eWianVD3TFhbQ1j+QRTT796YMJZMTKXrl9HCQ3aVYIQeEAzZA2LJl XkbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=4ndW9yXs78oys1ZvX7154IQPXTdG/uTxkPorVikndH4=; b=Uqaphrx3twn+IS3M2EPEr9Yj3+8qJqA4XvZAKHCUuWVBmvHM3Ann4PbfRF2MtMi2tM AHAdtmukxEj5Cl6jYeOEbU7Q5E+P/ZQ+jD2PgCMFVRLGHELUiXiOB6Jc6Q5nnALdhCuh l7XBO6cjuS/9Se518CiVlg1PGmyRRxkvtfSn8jWBtMkJJhj14CbMx+/uWF+K/UWukDWv MxnecMSOvQ+I0rD7c4+MYkSd3HTCdfRHe9rKRWFXLUOYdW4Qh4CmpEMOOGbLSo9XFJoQ 23cRH5RDauVcopHszCyUc9XL8Ruc1k6TXDwwaqufUGi9zncRhGaOr+AtTnX/0k348hCG h83Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si4701223ejx.493.2020.07.16.23.25.39; Thu, 16 Jul 2020 23:26:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgGQGWz (ORCPT + 99 others); Fri, 17 Jul 2020 02:22:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:36444 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726056AbgGQGWz (ORCPT ); Fri, 17 Jul 2020 02:22:55 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 328F1C9F7C738406320B; Fri, 17 Jul 2020 14:22:49 +0800 (CST) Received: from huawei.com (10.175.113.133) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 14:22:39 +0800 From: Wang Hai To: , , , , CC: , , Subject: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure Date: Fri, 17 Jul 2020 14:21:17 +0800 Message-ID: <20200717062117.8941-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.133] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to call destroy_workqueue when cxgb3 probe fails. Add the missed calls to fix it. Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 42c6e9379882..060d42803240 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -3407,6 +3407,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) out_disable_device: pci_disable_device(pdev); out: + destroy_workqueue(cxgb3_wq); return err; } -- 2.17.1