Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Jul 2020 08:28:41 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Daniel Gutson <daniel.gutson@eclypsium.com>
Cc:     Derek Kiernan <derek.kiernan@xilinx.com>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-kernel@vger.kernel.org, Richard Hughes <hughsient@gmail.com>,
        Alex Bazhaniuk <alex@eclypsium.com>
Subject: Re: [PATCH] [PATCH] Firmware security information in SYSFS
Message-ID: <20200717062841.GA3238569@kroah.com>
References: <20200716223627.253936-1-daniel.gutson@eclypsium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200716223627.253936-1-daniel.gutson@eclypsium.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 16, 2020 at 07:36:27PM -0300, Daniel Gutson wrote:
> +What:		/sys/kernel/firmware-security/bioswe

Ick, I stopped reading right here.

No, this is not where this belongs.

We already have /sys/firmware/, right?  And firmware-specific
subdirectories below that.

We also have /sys/devices/system/ and I think that would be a much
better place for this, as it is easier to work with a real 'struct
device' than a "raw" kobject any day.  Bonus is you get full support of
userspace libraries when you do that, unlike when dealing with kobjects.

Also, this really is a _SPECIFIC_ type of firmware that supports these
features, right?  Why not call that out too?  This is not generic by any
means.

thanks,

greg k-h