Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
Date:   Fri, 17 Jul 2020 14:40:17 +0800
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Liviu Dudau <liviu.dudau@arm.com>,
        Mihail Atanassov <mihail.atanassov@arm.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        nd@arm.com
Subject: Re: [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE
Message-ID: <20200717064017.GA76612@jamwan02-TSP300>
References: <20200716090333.13334-1-miaoqinglang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200716090333.13334-1-miaoqinglang@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (203.126.0.113) by SG2PR0401CA0008.apcprd04.prod.outlook.com (2603:1096:3:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Fri, 17 Jul 2020 06:40:22 +0000
X-Originating-IP: [203.126.0.113]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: a4a52939-4469-42c3-7099-08d82a1c4d4c
X-MS-TrafficTypeDiagnostic: DBBPR08MB4661:|HE1PR0802MB2188:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0802MB2188DABA85847F19DC615D82B37C0@HE1PR0802MB2188.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: Hy1/NdTR4VlyYMyW4GHE9TMrU5ArRXKsz8KtYTQVmuqkfp20hO2K3jTW2C/fgPAueatPH5041q1cdfr4ggu2RH3tK+zru591S/dxHWn0nQJCyPaQcv5/BeS9BFllucegk9XtXvy+mQlfgt1rs/xuZl2x9oTHGRTKTHVwUAlvRvNsfhhypSpkcauQ7xhDy+5XSZSUvLYfjgbfsd0ZgoWViyxib7DCcSFEiqYvkdBxsN0TY+Bp0wf+jV6oqOW/ax3JdB10uswGWCepA2VpvyYhSvWJaTCDtQI+mCqfHxaFQ3C0xY1MurH+PUX2F9IJiO2Yl4L7TsDoScBFJnmhXH7X4w==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB1719.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(7916004)(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(6496006)(8676002)(1076003)(316002)(6916009)(66556008)(9686003)(66946007)(33656002)(186003)(478600001)(956004)(16526019)(5660300002)(86362001)(26005)(33716001)(66476007)(83380400001)(52116002)(8936002)(4326008)(6666004)(6486002)(54906003)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 5rB3TEifZnW1Gb4OZy7LgYrKWA8L6l/Y+JpTzB8353fDUAqhY5w85nEWTr5MVGqKtQK2r3DqIBkksV6qs5fXMTSMmPqL4fNpuHm0ue73kZ9hdrjRApDNsZgh7G4WHXsoxqsUc+pahg3P4L29fc67+6OEyP9JrZ8xACbHi11PUPKKz7j+KeTEgpna8oOpY2x6zlF1VFCdr+XgRYrdMlk/CSpaWZ0niC5IvvVptAfAH/Co9EDblbsm8RRTF72bADUtr7ciz556lRAMk713IIK2cb575O7N6pzlYBBbMk7jAaKCa6woCzGBEPUVki7ffx6GoGwFDCCi604MwFpfgj/aRjvS++A11BhRo5CvFTvL91TmA4haK6J/yFNRlr3LGfYcr45Wu+x3zzTck9G0rfu7KpxxdeQ3gu3LX/F/a0/8UX1MIcNN/xr1x1eEf7f65ia9fEkjh+ZiEPxXVOgo3EH/yZmcoxVw3uszHC8J/DevkLo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4661
Original-Authentication-Results: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(7916004)(136003)(396003)(346002)(376002)(39860400002)(46966005)(336012)(8936002)(33716001)(186003)(956004)(6862004)(70206006)(82740400003)(70586007)(86362001)(16526019)(26005)(1076003)(47076004)(83380400001)(4326008)(6486002)(2906002)(54906003)(9686003)(5660300002)(356005)(33656002)(36906005)(6496006)(8676002)(316002)(6666004)(81166007)(478600001)(82310400002);DIR:OUT;SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 4d29ef94-abc7-404f-201a-08d82a1c4843
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: stzHQVNh4wHyfkYSxlDZdmWRhj8AYOyG7ZR5mmaPi5YhhhhSTLxZrYEqeNw9T3enYERS77z+xqTx19pPvOwnfPTiFme3AQCcQZC+X0YcsN2F0vVPb2iOXz4g6JGnYVX8A1g6WrhTbZf77V8TZZZHn0mI4C3H9R+YS7Fwo61SWlwtnyORKaVkRV3bmHzRC/EjluhuzIZ2ZI70e+Nums84jodcJEO/N8Of7B8eT6aSiHvZXe9TcxHTB1OcUNVWA6aAfy2FYkMBvViSrAV3IlkC0QRBIpQ5nTUAQyVuTyIqh9+RyivlUjITmji6DcDdY0KCBmrRjx/h/bB1upCJbrwTTeZNVp2qoWe9ItYOOwYJ/6MxTWxi3NQyKyJHoOByr3ymbmWcGX7bX4kGntwr9tokEw==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 06:40:31.5951
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a4a52939-4469-42c3-7099-08d82a1c4d4c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2188
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 16, 2020 at 05:03:33PM +0800, Qinglang Miao wrote:
> From: Liu Shixin <liushixin2@huawei.com>
> 
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 0246b2e94..4a10e6b9e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -41,18 +41,7 @@ static int komeda_register_show(struct seq_file *sf, void *x)
>  	return 0;
>  }
>  
> -static int komeda_register_open(struct inode *inode, struct file *filp)
> -{
> -	return single_open(filp, komeda_register_show, inode->i_private);
> -}
> -
> -static const struct file_operations komeda_register_fops = {
> -	.owner		= THIS_MODULE,
> -	.open		= komeda_register_open,
> -	.read_iter		= seq_read_iter,
> -	.llseek		= seq_lseek,
> -	.release	= single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(komeda_register);
>

Hi Shixin & Qinglang

Thanks for your patch.

Reviewed-by: James Qian Wang <james.qian.wang@arm.com>

Since your patch is not for drm-misc-next, so seems better
to leave it to you to merge it. :)

Thanks
James

>  #ifdef CONFIG_DEBUG_FS
>  static void komeda_debugfs_init(struct komeda_dev *mdev)
> -- 
> 2.17.1