Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1778837ybh; Fri, 17 Jul 2020 00:22:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8ZOeMHAiVs5asHquKbaaXGEicoNOWYFg5zB+KvJ5VlQHq6QHxFJat7E2RO4qnnq1zBKd5 X-Received: by 2002:a17:907:2170:: with SMTP id rl16mr7722728ejb.422.1594970561031; Fri, 17 Jul 2020 00:22:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594970561; cv=none; d=google.com; s=arc-20160816; b=EA7PUkK7psKRh9B9qYvAipjKBPPyMCWv/eK2Im7zwqUGpKasRjslRr+fzEXUWuRNYe BseUhnHf6tnt1FC8onwdVlBhbp66bTfD7Tj5s10UU82oB2o/0J7ZOs341wTJf4WWzC5+ txcBKx3Nkg7DNk9zPPeEaFZ/9lRwEZomavZvKcYYCnH46lYE1srLvB4VwpOaLRMiFjRT EnJYnSfKOPIxHXvh86BzAYrXHeMFqsYo6nHcTTkxpXp7kxMbS5of9mu4WGM93PIu6Vzr LZLte4ve81/Yncf85f+aX6S4Bfvrj+W28YrQsqhuJsEYNIgPTmhvk6HZeBAOluGEe/o3 70wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:ironport-sdr:ironport-sdr; bh=HOqNN+0nZbQUL/p/a4yRngev38OvZ2UQeogbN7JcjWU=; b=bXwaFs7kqj1vwDyrrV0xPu3UiPPDKAHnzzhdGEmDp5cqr+32n4VviyQ1be+g0pp6da 0RZlkNF+f+nRTaQspY1oVG1WdmvKcEdm4PB3J4/+PWOAwhJjysTLsAFmyzlkb6Uq0h5o Zc7krKsMnlSREiXAGjy6a+s1HeZHMjS4QfKP9QbIc74NBH3ryCL9+0myAND5hmgJyYgD GUS5p0lcgCvphxtYTxxSCSOIxPEoRyAfQG5Yi5+wtJxYOdOxJQRoPjq6NQfP3H04zyvw FzlDODUTf62YZGF0if66oWNYtQihaiF+PlzTPVL8fh69hZSCluJht48JdpLjza9AKWrz TkPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si4764028edp.98.2020.07.17.00.22.18; Fri, 17 Jul 2020 00:22:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbgGQHVo (ORCPT + 99 others); Fri, 17 Jul 2020 03:21:44 -0400 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:18959 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728089AbgGQHVj (ORCPT ); Fri, 17 Jul 2020 03:21:39 -0400 IronPort-SDR: 7LaXq6ihs9ev2HrxcLAVdfggmpJnNuVWLGB/RpKt09UAWQeAakDX6oTlGIcMOWRSZj+fi1Y+vI GdZ1TLY/hvk0/nvxGUzzzlDoc2Ipp5Xn2KMQjd/6mSCLJDvL4QsZwRGOPDPCBVELvsf7iDq+zY u/Sj1ZDcfDtPovQSNjT7mgvo53GhdNw6t783bOatrca+nE6fHOA+TT0g2emzV+B0OBInO+oJda yWUnon6fNON1SBbdys/Xa+iiwrQ9c4eDoIz6B+NGxuIZXcucmTXUB7WxNk0Qp4JdPuUS5qS6Ul L9I= X-IronPort-AV: E=Sophos;i="5.75,362,1589270400"; d="scan'208";a="51006580" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 16 Jul 2020 23:21:38 -0800 IronPort-SDR: 30y6cLVJUlFgj1xzSnpRyflWc2zU7F73h3pTMum+dRAQLEKdgW1r3qLL/FOt2E+iyPf8h43COL sLaRq4+gZzTZ7gcZywveVT2tktMtlcwTGaOQcVZV4+Ruqwbx6QA5yimTxNButuuK9ocEx9YIB+ HN9vXZ3v8YFqYFVnfKkG5FDIuLaAaoaIsQji2C0kl2QJEA7PX7qevd8XWYvbEvafGwIWC2gc3B bDDqkaKdDCdN4WhluZKAj6KtyWeVqNF38X8FZApqRzLajYUnQ/oItP12D/1al9schiuytX7Xo4 aCg= Subject: Re: [PATCH v11 00/56] atmel_mxt_ts misc From: "Wang, Jiada" To: Dmitry Torokhov CC: , , , , , , , References: <20200508055656.96389-1-jiada_wang@mentor.com> <20200527064307.GK89269@dtor-ws> <2f7964da-0dca-2d13-3559-28b4582a3278@mentor.com> <80fc7a3e-efd5-fab8-8ba8-8aa011944ab1@mentor.com> Message-ID: Date: Fri, 17 Jul 2020 16:21:32 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <80fc7a3e-efd5-fab8-8ba8-8aa011944ab1@mentor.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello All I am thinking it doesn't make sense to keep the series with such a big chunk of patches, I will divide the series into several small series Thanks, Jiada On 2020/07/08 22:05, Wang, Jiada wrote: > Hello Dmitry > > I am working on refining this series, > regarding your comment about drop changes related to > upload firmware and config during boot. > > I found currently only config is uploaded during every boot. > but firmware is only uploaded when userspace asks to do so via > sysfs interface. > > Could you help to confirm if this is the case? > > Thanks, > Jiada > > On 2020/06/25 22:50, Wang, Jiada wrote: >> Hello Dmitry >> >> sorry for the delay, >> >> On 2020/05/27 15:43, Dmitry Torokhov wrote: >>> Hi Jiada, >>> >>> On Thu, May 07, 2020 at 10:56:00PM -0700, Jiada Wang wrote: >>>> This patch-set forward ports Nick Dyer's work in ndyer/linux github >>>> repository as long as some other features and fixes >>> >>> Sorry for ignoring the series for quite a while. I guess my biggest >>> issue with the series is that quite a bit of patches are trying to >>> handle the fallout from a very unfortunate design decision in the >>> driver: the fact that it attempts to automatically upload firmware and >>> config on every boot/probe. This design was done at my urging because I >>> did not have access to the technical documentation and did not realize >>> that the controller has non-volatile memory for both firmware and >>> configuration. We should only attempt to automatically load firmware >>> where device does not have non-volatile memory and is unable function >>> otherwise, in all other cases we better leave it to userspace to decide >>> whether to execute firmware update and when. The kernel should only >>> provide facilities so that userspace can initiate firmware update. This >>> design has worked well for Chrome OS for many years (it used Atmel >>> controllers in several products), and I would like to bring it to the >>> mainline. >> >> I agree with you, I will review the patch-set, >> and only pick these not related to firmware/cfg upload >> >> Thanks, >> jiada >>> >>> Thanks. >>>